Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BWC tests for running against distribution bundle #587

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Dec 30, 2022

Description

This PR would also include my previous PR #519

Add option to run BWC tests in distribution level, which is running tests in the test cluster with latest distribution bundle installed and all plugins (included in the latest manifest) present.

The command to run BWC tests in distribution level would be ./gradlew bwcTestSuite -Dtests.security.manager=false -PcustomDistributionDownloadType=bundle
If property customDistributionDownloadType is not set nor set to bundle, the BWC tests would be default to run in plugins level as previously configured.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team December 30, 2022 01:23
@zelinh zelinh mentioned this pull request Dec 30, 2022
1 task
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #587 (91b241d) into 2.x (41139ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #587   +/-   ##
=========================================
  Coverage     70.74%   70.74%           
  Complexity      112      112           
=========================================
  Files           124      124           
  Lines          3951     3951           
  Branches        617      630   +13     
=========================================
  Hits           2795     2795           
  Misses          976      976           
  Partials        180      180           
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)
opensearch-notifications 61.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@qreshi
Copy link
Contributor

qreshi commented Jan 10, 2023

I think this was asked in another similar PR but is there a reason we're not submitting this against main first? Our BWC should be running fine there so I'd prefer we go in order.

@zelinh zelinh added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 10, 2023
@zelinh
Copy link
Member Author

zelinh commented Jan 10, 2023

I think this was asked in another similar PR but is there a reason we're not submitting this against main first? Our BWC should be running fine there so I'd prefer we go in order.

Currently the distribution build for our 3.0.0 are not stable and I haven't validated these tests for major version update. So we are targeting to 2.5 version for now. I could draft a new PR to backport on main when we getting close to it.

@zelinh
Copy link
Member Author

zelinh commented Jan 10, 2023

Confirmed with @qreshi that the CI failure on dashboards notification is a known issue and not related to this PR. Merging now.

@zelinh zelinh merged commit 027018e into opensearch-project:2.x Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add bwc tests for bundle distribution

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Dynamically set the bwc version

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 027018e)
@zelinh zelinh deleted the bundle-bwc-test branch January 10, 2023 23:05
lezzago pushed a commit that referenced this pull request Jan 10, 2023
* Add bwc tests for bundle distribution

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

* Dynamically set the bwc version

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
(cherry picked from commit 027018e)

Co-authored-by: Zelin Hao <zelinhao@amazon.com>
@qreshi qreshi mentioned this pull request Jan 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.5 v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants