-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable windows and macos builds #1108
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
.github/workflows/dashboards-observability-test-and-build-workflow.yml
Outdated
Show resolved
Hide resolved
.github/workflows/opensearch-observability-test-and-build-workflow.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: the artifacts should be the same for all platforms right?
.github/workflows/dashboards-observability-test-and-build-workflow.yml
Outdated
Show resolved
Hide resolved
cd OpenSearch-Dashboards/plugins/dashboards-observability | ||
yarn osd bootstrap | ||
|
||
# TODO remove hard coded version when observability is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the comment if not used.
cd OpenSearch-Dashboards/plugins/dashboards-observability | ||
yarn osd bootstrap | ||
|
||
# TODO remove hard coded version when observability is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
.github/workflows/opensearch-observability-test-and-build-workflow.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1108 +/- ##
============================================
+ Coverage 53.12% 53.53% +0.40%
Complexity 291 291
============================================
Files 280 279 -1
Lines 9428 9439 +11
Branches 2208 2209 +1
============================================
+ Hits 5009 5053 +44
+ Misses 4249 4216 -33
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
- os: windows-latest | ||
os_build_args: -x integTest -x jacocoTestReport | ||
- os: macos-latest | ||
os_build_args: -x integTest -x jacocoTestReport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are integ tests failing? Please open an issue to get those to work on those OSs as well in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done #1159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Let's make sure to follow on integ-tests later
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1108-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 363ccd4946fcbb9280078e694846e9aa8a8753b0
# Push it to GitHub
git push --set-upstream origin backport/backport-1108-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1108-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 363ccd4946fcbb9280078e694846e9aa8a8753b0
# Push it to GitHub
git push --set-upstream origin backport/backport-1108-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* feat: enable windows and macos builds (#1108) * fix: initial code to add windows support for opensearch-observability Signed-off-by: Derek Ho <dxho@amazon.com> * add build for windows in dashboards-observability Signed-off-by: Derek Ho <dxho@amazon.com> * change windows command and add windows build for UI modules Signed-off-by: Derek Ho <dxho@amazon.com> * try gradlew bat for windows Signed-off-by: Derek Ho <dxho@amazon.com> * try to exclude tests Signed-off-by: Derek Ho <dxho@amazon.com> * fix jacoco Signed-off-by: Derek Ho <dxho@amazon.com> * do for mac and change name Signed-off-by: Derek Ho <dxho@amazon.com> * try to run the tests for windows and mac Signed-off-by: Derek Ho <dxho@amazon.com> * try to add gitattributes file Signed-off-by: Derek Ho <dxho@amazon.com> * add formatting rule Signed-off-by: Derek Ho <dxho@amazon.com> * try to enable both Signed-off-by: Derek Ho <dxho@amazon.com> * try to add git config to fix Signed-off-by: Derek Ho <dxho@amazon.com> * autocrlf false for windwos and remove comments Signed-off-by: Derek Ho <dxho@amazon.com> * comment out bwc tests, Signed-off-by: Derek Ho <dxho@amazon.com> * add line Signed-off-by: Derek Ho <dxho@amazon.com> * fix up using matrix and fix test Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 363ccd4) Signed-off-by: Derek Ho <dxho@amazon.com> * remove java 17 Signed-off-by: Derek Ho <dxho@amazon.com> * remove -d for windows Signed-off-by: Derek Ho <dxho@amazon.com> * Update .github/workflows/dashboards-observability-test-and-build-workflow.yml Signed-off-by: Derek Ho <dxho@amazon.com> * fix fail fast Signed-off-by: Derek Ho <dxho@amazon.com> * try to do fix step for mac Signed-off-by: Derek Ho <dxho@amazon.com> * remove mac Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>
* feat: enable windows and macos builds (#1108) * fix: initial code to add windows support for opensearch-observability Signed-off-by: Derek Ho <dxho@amazon.com> * add build for windows in dashboards-observability Signed-off-by: Derek Ho <dxho@amazon.com> * change windows command and add windows build for UI modules Signed-off-by: Derek Ho <dxho@amazon.com> * try gradlew bat for windows Signed-off-by: Derek Ho <dxho@amazon.com> * try to exclude tests Signed-off-by: Derek Ho <dxho@amazon.com> * fix jacoco Signed-off-by: Derek Ho <dxho@amazon.com> * do for mac and change name Signed-off-by: Derek Ho <dxho@amazon.com> * try to run the tests for windows and mac Signed-off-by: Derek Ho <dxho@amazon.com> * try to add gitattributes file Signed-off-by: Derek Ho <dxho@amazon.com> * add formatting rule Signed-off-by: Derek Ho <dxho@amazon.com> * try to enable both Signed-off-by: Derek Ho <dxho@amazon.com> * try to add git config to fix Signed-off-by: Derek Ho <dxho@amazon.com> * autocrlf false for windwos and remove comments Signed-off-by: Derek Ho <dxho@amazon.com> * comment out bwc tests, Signed-off-by: Derek Ho <dxho@amazon.com> * add line Signed-off-by: Derek Ho <dxho@amazon.com> * fix up using matrix and fix test Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 363ccd4) Signed-off-by: Derek Ho <dxho@amazon.com> * fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>
* feat: enable windows and macos builds (#1108) * fix: initial code to add windows support for opensearch-observability Signed-off-by: Derek Ho <dxho@amazon.com> * add build for windows in dashboards-observability Signed-off-by: Derek Ho <dxho@amazon.com> * change windows command and add windows build for UI modules Signed-off-by: Derek Ho <dxho@amazon.com> * try gradlew bat for windows Signed-off-by: Derek Ho <dxho@amazon.com> * try to exclude tests Signed-off-by: Derek Ho <dxho@amazon.com> * fix jacoco Signed-off-by: Derek Ho <dxho@amazon.com> * do for mac and change name Signed-off-by: Derek Ho <dxho@amazon.com> * try to run the tests for windows and mac Signed-off-by: Derek Ho <dxho@amazon.com> * try to add gitattributes file Signed-off-by: Derek Ho <dxho@amazon.com> * add formatting rule Signed-off-by: Derek Ho <dxho@amazon.com> * try to enable both Signed-off-by: Derek Ho <dxho@amazon.com> * try to add git config to fix Signed-off-by: Derek Ho <dxho@amazon.com> * autocrlf false for windwos and remove comments Signed-off-by: Derek Ho <dxho@amazon.com> * comment out bwc tests, Signed-off-by: Derek Ho <dxho@amazon.com> * add line Signed-off-by: Derek Ho <dxho@amazon.com> * fix up using matrix and fix test Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 0e65c32) Signed-off-by: Derek Ho <dxho@amazon.com> * remove java 17 Signed-off-by: Derek Ho <dxho@amazon.com> * remove -d for windows Signed-off-by: Derek Ho <dxho@amazon.com> * Update .github/workflows/dashboards-observability-test-and-build-workflow.yml Signed-off-by: Derek Ho <dxho@amazon.com> * fix fail fast Signed-off-by: Derek Ho <dxho@amazon.com> * try to do fix step for mac Signed-off-by: Derek Ho <dxho@amazon.com> * remove mac Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>
Description
Enable builds on windows and macos
Issues Resolved
#160 #161
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.