Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add configurable iterations parameters per operation #393

Closed
12 tasks done
OVI3D0 opened this issue Sep 19, 2024 · 2 comments
Closed
12 tasks done

[FEATURE] Add configurable iterations parameters per operation #393

OVI3D0 opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@OVI3D0
Copy link
Member

OVI3D0 commented Sep 19, 2024

What solution would you like?

Similar to #120 , workloads should also have configurable iteration parameters per operation. This is would help for OSB's new Aggregate command. In the event where users customize the amount of iterations they want certain operations to run, the aggregate command should then be able to take these custom values into consideration when performing the calculation for the aggregated results.

Updating the workloads to use something like this could help:

        {
          "operation": "default",
          "warmup-iterations": {{ default_warmup_iterations or warmup_iterations | default(50) | tojson }},
          "iterations": {{ default_iterations or iterations | default(100) | tojson }},
          "target-throughput": {{ default_target_throughput or target_throughput | default(3) | tojson }},
          "clients": {{ default_clients or search_clients | default(1) }}
        }
@OVI3D0 OVI3D0 added enhancement New feature or request untriaged labels Sep 19, 2024
@peterzhuamazon peterzhuamazon moved this from 🆕 New to 🏗 In progress in Engineering Effectiveness Board Sep 23, 2024
@OVI3D0 OVI3D0 moved this from 🏗 In progress to ⌛ On Hold in Engineering Effectiveness Board Oct 1, 2024
@OVI3D0 OVI3D0 moved this from ⌛ On Hold to 🏗 In progress in Engineering Effectiveness Board Oct 7, 2024
@OVI3D0 OVI3D0 moved this from 🏗 In progress to 👀 In review in Engineering Effectiveness Board Oct 15, 2024
@OVI3D0 OVI3D0 moved this from 👀 In review to ✅ Done in Engineering Effectiveness Board Oct 21, 2024
@IanHoang
Copy link
Collaborator

Thanks for the help @OVI3D0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants