Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support custom iteration values in new aggregate command #670

Closed
OVI3D0 opened this issue Oct 3, 2024 · 0 comments · Fixed by #696
Closed

[FEATURE] Support custom iteration values in new aggregate command #670

OVI3D0 opened this issue Oct 3, 2024 · 0 comments · Fixed by #696
Assignees
Labels
enhancement New feature or request

Comments

@OVI3D0
Copy link
Member

OVI3D0 commented Oct 3, 2024

Is your feature request related to a problem? Please describe

Currently, the new aggregate command calculates weighted averages for metrics using the number of iterations for each operation. However, some users may want to run their workloads with custom iteration values. We should update the aggregate command so it can support cases where users want to run operations with custom values.

Describe the solution you'd like

First, the workloads should be updated to support configurable iteration values. This way, there are named values that can be accessed to check if users ran a workload with custom iteration values. The aggregator class should then perform a check for these values and use them when calculating the weighted averages for each value.

Describe alternatives you've considered

No response

Additional context

No response

@OVI3D0 OVI3D0 added enhancement New feature or request untriaged labels Oct 3, 2024
@IanHoang IanHoang removed the untriaged label Oct 3, 2024
@OVI3D0 OVI3D0 moved this from 🆕 New to 🏗 In progress in Engineering Effectiveness Board Oct 28, 2024
@OVI3D0 OVI3D0 moved this from 🏗 In progress to ⌛ On Hold in Engineering Effectiveness Board Oct 30, 2024
@OVI3D0 OVI3D0 moved this from ⌛ On Hold to 🏗 In progress in Engineering Effectiveness Board Nov 18, 2024
@OVI3D0 OVI3D0 linked a pull request Nov 19, 2024 that will close this issue
1 task
@OVI3D0 OVI3D0 moved this from 🏗 In progress to 👀 In review in Engineering Effectiveness Board Nov 26, 2024
@peterzhuamazon peterzhuamazon moved this from 📋 Escalation to 👀 In Review in Engineering Effectiveness Board Dec 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants