-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default param values #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
requested review from
IanHoang,
gkamat,
beaioun and
cgchinmay
as code owners
March 7, 2024 21:40
IanHoang
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IanHoang
added
backport 2
Backport to the "2" branch
backport 1
backport 3
Backport to the "3" branch
labels
Mar 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 127aa45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 127aa45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 127aa45) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit 127aa45) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit 127aa45) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit 127aa45) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/opensearch-benchmark-workloads
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update default param values to increase merge time out for large dataset and reduce segment count for smaller datasets.
By removing merge timeout, default value will be used.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.