Add new procedure for AOSS #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay and
rishabh6788
as code owners
|
We need to add "sleep" operation for at least 90s between delete/create/index/search for AOSS. Will be adding once |
VijayanB
force-pushed
the
add-aoss
branch
4 times, most recently
from
1be8bbd to
a2b7127
Compare
jmazanec15
reviewed
Mar 20, 2024
|
please backport to 1.x and 2.x |
|
@IanHoang @rishabh6788 @gkamat Can i get review for this? |
jmazanec15
approved these changes
Mar 22, 2024
VijayanB
force-pushed
the
add-aoss
branch
2 times, most recently
from
650ac1f to
b9aa30b
Compare
gkamat
requested changes
Mar 22, 2024
| @@ -16,6 +16,11 @@ | |||
| "mappings": { | |||
| "dynamic": "strict", | |||
| "properties": { | |||
| {%- if id_field_name is defined and id_field_name != "_id" %} | |||
There was a problem hiding this comment.
The {%- syntax can probably be replaced by {% in this context.
Please add this workload parameter to the README for completeness.
Likewise, please add information on the new workload parameter files there as well.
There was a problem hiding this comment.
Thanks for review @gkamat . I updated PR. Can you please take a look at updated PR? Thanks.
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
gkamat
approved these changes
Mar 25, 2024
gkamat
added
backport 2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit ddf643b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit ddf643b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Mar 25, 2024
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. (cherry picked from commit ddf643b) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Mar 25, 2024
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. (cherry picked from commit ddf643b) Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/opensearch-benchmark-workloads
that referenced
this pull request
Jul 16, 2024
AOSS doesn't allow users to pass value to "_id". Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AOSS doesn't allow users to pass value to "_id".
Hence, create a new procedure and param to support user defined field "id" as unique field to identify document from index.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.