add range agg in noaa and big5 workloads #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
changed the title
9 tasks
bowenlan-amzn
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
IanHoang
reviewed
Jun 17, 2024
| "field": "TMAX", | ||
| "ranges": [ | ||
| {"to": -10}, | ||
| {"from": -10, "to": 0}, |
There was a problem hiding this comment.
Nit: Can we standardize on the JSON format we used in big5?
From
{"from": 0, "to": 10},
To
{
"from": 0,
"to": 10
},
There was a problem hiding this comment.
In this json, the format is like this. I think if we want to format, better to do in a different PR.
There was a problem hiding this comment.
Makes sense. I see it in the subsequent operations.
IanHoang
reviewed
Jun 17, 2024
| "name": "range-agg-1", | ||
| "operation-type": "search", | ||
| "index": "{{index_name | default('big5')}}", | ||
| "body": { |
There was a problem hiding this comment.
Is there a reason why we don't include "request-timeout": 7200, in range-agg-1?
There was a problem hiding this comment.
Good catch. This 2 range aggregation operations are actually copied from existing range-auto-date-histo and range-auto-date-histo-with-metrics. I think "request-timeout": 7200 is just needed when the request is by default taking long time. So I will remove this from range-agg-2
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
IanHoang
added
backport 2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * add range agg Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * address comments Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 12504df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * add range agg Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * address comments Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 12504df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * add range agg Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * address comments Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 12504df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa * add range agg * address comments --------- (cherry picked from commit 12504df) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa * add range agg * address comments --------- (cherry picked from commit 12504df) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add range agg in noaa * add range agg * address comments --------- (cherry picked from commit 12504df) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/opensearch-benchmark-workloads
that referenced
this pull request
Jul 16, 2024
* add range agg in noaa Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * add range agg Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * address comments Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In OpenSearch 13865, previous date histogram aggregation optimization is now applied to range aggregation. So adding operations to track the performance from now on.
Issues Resolved
Related opensearch-project/OpenSearch#13865
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.