Add vectorsearch training workload #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Finn Roblin <finnrobl@amazon.com>
finnroblin
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
2 tasks
VijayanB
reviewed
Jun 25, 2024
Comment on lines
12
to
13
| "target_index_num_vectors": 1000, | ||
|
|
There was a problem hiding this comment.
can we remove "target_index_num_vectors" from param file?
finnroblin
commented
Jun 25, 2024
| } | ||
| ], | ||
| "corpora": [ | ||
| { | ||
| "name": "cohere", | ||
| "base-url": "https://dbyiw3u3rf9yr.cloudfront.net/corpora/vectorsearch/cohere-wikipedia-22-12-en-embeddings", | ||
| "target-index": "{{ target_index_name }}", |
There was a problem hiding this comment.
Calling out here that this target-index param is not used anywhere in the workload, but it's necessary due to OSB validation. I'm not sure what the solution is, but I opened an issue about this.
Signed-off-by: Finn Roblin <finnrobl@amazon.com>
IanHoang
added
backport 2
IanHoang
reviewed
Jul 2, 2024
There was a problem hiding this comment.
@finnroblin Overall, LGTM. As per best practices specified in the README, please provide a sample summary output of train-test in the PR description.
Signed-off-by: Finn Roblin <finnrobl@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add vectorsearch training workload Signed-off-by: Finn Roblin <finnrobl@amazon.com> * Addressed Vijay feedback and ignores error if model DNE Signed-off-by: Finn Roblin <finnrobl@amazon.com> * Added documentation to VS readme Signed-off-by: Finn Roblin <finnrobl@amazon.com> --------- Signed-off-by: Finn Roblin <finnrobl@amazon.com> (cherry picked from commit 29d9715) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add vectorsearch training workload Signed-off-by: Finn Roblin <finnrobl@amazon.com> * Addressed Vijay feedback and ignores error if model DNE Signed-off-by: Finn Roblin <finnrobl@amazon.com> * Added documentation to VS readme Signed-off-by: Finn Roblin <finnrobl@amazon.com> --------- Signed-off-by: Finn Roblin <finnrobl@amazon.com> (cherry picked from commit 29d9715) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add vectorsearch training workload * Addressed Vijay feedback and ignores error if model DNE * Added documentation to VS readme --------- (cherry picked from commit 29d9715) Signed-off-by: Finn Roblin <finnrobl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add vectorsearch training workload * Addressed Vijay feedback and ignores error if model DNE * Added documentation to VS readme --------- (cherry picked from commit 29d9715) Signed-off-by: Finn Roblin <finnrobl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
train-testvectorsearch workload to benchmark kNN operations that require training like faiss ivf. Please see issue #332 for context.This PR adds a schedule to train kNN algorithms using the train-knn-model operation proposal in OSB PR 556. It depends on the operation runners in that PR. It also requires an additional index in the vectorsearch
workload.jsonto hold training data.The
train-testworkload on my branch works on the faiss-sift-128 dataset without breaking backwards compatibility with other vectorsearch workloads. Please feel free to clone my forks (OSB, OSB Workload) to investigate workload behavior, as there are not unit tests in the OSB workloads framework.Issues Resolved
Closes #332
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Sample Output: