-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new aoss vector search param fields target_throughput
, repetitions
and time_period
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com>
…-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com>
aseghehey
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
July 2, 2024 20:59
VijayanB
reviewed
Jul 2, 2024
Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com>
VijayanB
approved these changes
Jul 3, 2024
VijayanB
added
backport 2
Backport to the "2" branch
backport 1
backport 3
Backport to the "3" branch
labels
Jul 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
…titions` and `time_period` (#334) * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> * Adding default values to repetitions and time_period Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com> --------- Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com> Co-authored-by: Emanuel Aseghehey <aseghey@amazon.com> (cherry picked from commit f4a830e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-334-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4a830eb31451e4df76e56016684641dc373793c
# Push it to GitHub
git push --set-upstream origin backport/backport-334-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3 Then, create a pull request where the |
VijayanB
pushed a commit
that referenced
this pull request
Jul 3, 2024
…titions` and `time_period` (#334) (#335) * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure * Adding default values to repetitions and time_period --------- (cherry picked from commit f4a830e) Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Emanuel Aseghehey <aseghey@amazon.com>
harshavamsi
pushed a commit
to harshavamsi/opensearch-benchmark-workloads
that referenced
this pull request
Jul 16, 2024
…titions` and `time_period` (opensearch-project#334) * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> * Adding target_throughput, repetitions and time_period to aoss' search-only test procedure Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> * Adding default values to repetitions and time_period Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com> --------- Signed-off-by: Emanuel Aseghehey <aseghey@amazon.com> Signed-off-by: Emanuel Aseghehey <emanuelaseghey9@gmail.com> Co-authored-by: Emanuel Aseghehey <aseghey@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
As per request in issue 317, AOSS would like to have granular control over of load during benchmarking by controlling the targeted TPS for workload as well as the duration of the load.
This PR adds the fields
target_throughput
,time_period
andrepetitions
to AOSS' vector search procedure. This was tested, and I was able to validate it locally.Local test details
Tested with the following params:
Ran command:
Output, which I observed the max throughput did not exceed 15 and the test did not last over 1500s:
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.