Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Semantic search on NOAA increasing number of search clients to 8 #340

Conversation

martin-gaievski
Copy link
Member

Description

Increasing number of search clients for semantic search workload that is based on noaa dataset. I'm setting number of search clients to 8. That will make throughput results more reliable comparing to what we have today. Currently we don't have any custom setting for number of search clients in param files, that means we're using default number which is 1. Below is example of throughput metrics from the same system for 7 days period, expectation is that graph is more or less smooth, but it has some spikes:

image

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@IanHoang IanHoang added backport 2 Backport to the "2" branch backport 1 backport 3 Backport to the "3" branch labels Jul 10, 2024
@VijayanB VijayanB merged commit 392670d into opensearch-project:main Jul 17, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2024
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 392670d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1 1
# Navigate to the new working tree
pushd ../.worktrees/backport-1
# Create a new branch
git switch --create backport/backport-340-to-1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 392670dbd86ac7447e11210401d9f67fad0ebebf
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1

Then, create a pull request where the base branch is 1 and the compare/head branch is backport/backport-340-to-1.

@opensearch-trigger-bot
Copy link

The backport to 3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-340-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 392670dbd86ac7447e11210401d9f67fad0ebebf
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3

Then, create a pull request where the base branch is 3 and the compare/head branch is backport/backport-340-to-3.

IanHoang pushed a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit 392670d)

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang pushed a commit to IanHoang/opensearch-benchmark-workloads that referenced this pull request Jul 18, 2024
…ensearch-project#343)

(cherry picked from commit 392670d)

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang added a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit 392670d)

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1 backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants