-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Semantic search on NOAA increasing number of search clients to 8 #340
Merged
VijayanB
merged 1 commit into
opensearch-project:main
from
martin-gaievski:increase_num_of_search_clients_for_semantic_search_noaa
Jul 17, 2024
Merged
For Semantic search on NOAA increasing number of search clients to 8 #340
VijayanB
merged 1 commit into
opensearch-project:main
from
martin-gaievski:increase_num_of_search_clients_for_semantic_search_noaa
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
July 10, 2024 17:53
IanHoang
approved these changes
Jul 10, 2024
IanHoang
added
backport 2
Backport to the "2" branch
backport 1
backport 3
Backport to the "3" branch
labels
Jul 10, 2024
VijayanB
approved these changes
Jul 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 392670d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1 1
# Navigate to the new working tree
pushd ../.worktrees/backport-1
# Create a new branch
git switch --create backport/backport-340-to-1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 392670dbd86ac7447e11210401d9f67fad0ebebf
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-340-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 392670dbd86ac7447e11210401d9f67fad0ebebf
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3 Then, create a pull request where the |
IanHoang
pushed a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 392670d) Signed-off-by: Martin Gaievski <gaievski@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
to IanHoang/opensearch-benchmark-workloads
that referenced
this pull request
Jul 18, 2024
…ensearch-project#343) (cherry picked from commit 392670d) Signed-off-by: Martin Gaievski <gaievski@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
added a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 392670d) Signed-off-by: Martin Gaievski <gaievski@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing number of search clients for semantic search workload that is based on noaa dataset. I'm setting number of search clients to 8. That will make throughput results more reliable comparing to what we have today. Currently we don't have any custom setting for number of search clients in param files, that means we're using default number which is 1. Below is example of throughput metrics from the same system for 7 days period, expectation is that graph is more or less smooth, but it has some spikes:
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.