Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename params with default operation names in http-logs #499

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

OVI3D0
Copy link
Member

@OVI3D0 OVI3D0 commented Nov 14, 2024

Description

There were several tasks in the http-logs workload with 'default' operation values. The new configurable parameters are typically prefixed with the operation value, but these operations in http-logs were renamed to use the 'name' values instead, so there are not several operations with shared parameter names.

Backport to Branches:

  • 6
  • 7
  • 1
  • 2
  • 3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@OVI3D0 OVI3D0 added backport 2 Backport to the "2" branch backport 1 backport 3 Backport to the "3" branch backport 7 Backport to the "7" branch labels Nov 14, 2024
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
@IanHoang IanHoang merged commit 2e8adf8 into opensearch-project:main Nov 14, 2024
2 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2024
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
(cherry picked from commit 2e8adf8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1 1
# Navigate to the new working tree
pushd ../.worktrees/backport-1
# Create a new branch
git switch --create backport/backport-499-to-1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1

Then, create a pull request where the base branch is 1 and the compare/head branch is backport/backport-499-to-1.

@opensearch-trigger-bot
Copy link

The backport to 3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-499-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3

Then, create a pull request where the base branch is 3 and the compare/head branch is backport/backport-499-to-3.

@opensearch-trigger-bot
Copy link

The backport to 7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-7 7
# Navigate to the new working tree
pushd ../.worktrees/backport-7
# Create a new branch
git switch --create backport/backport-499-to-7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e8adf8ed75a239e0bd45a87e46d5003acdb7c27
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-7

Then, create a pull request where the base branch is 7 and the compare/head branch is backport/backport-499-to-7.

IanHoang pushed a commit that referenced this pull request Nov 14, 2024
(cherry picked from commit 2e8adf8)

Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@OVI3D0 OVI3D0 deleted the http-logs-update branch November 19, 2024 23:08
joshpalis pushed a commit to joshpalis/opensearch-benchmark-workloads that referenced this pull request Dec 18, 2024
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1 backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch backport 7 Backport to the "7" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants