Skip to content

Commit

Permalink
Add TODO to support more levels of nesting in the future
Browse files Browse the repository at this point in the history
Signed-off-by: Finn Roblin <finnrobl@amazon.com>
  • Loading branch information
finnroblin committed Jul 22, 2024
1 parent 26b0d8d commit acb9e94
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion osbenchmark/workload/params.py
Original file line number Diff line number Diff line change
Expand Up @@ -983,9 +983,12 @@ def partition(self, partition_index, total_partitions):

def get_split_fields(self) -> Tuple[str, str]:
fields_as_array = self.field_name.split(self.NESTED_FIELD_SEPARATOR)

# TODO: Add support to multiple levels of nesting if a future benchmark requires it.

if len(fields_as_array) != 2:
raise ValueError(
f"Field name {self.field_name} is not a nested field name"
f"Field name {self.field_name} is not a nested field name. Currently we support only 1 level of nesting."
)
return fields_as_array[0], fields_as_array[1]

Expand Down

0 comments on commit acb9e94

Please sign in to comment.