-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Can't use benchmark and jupyter notebook in the same python env as their dependency versions conflict #499
Comments
Thanks for bringing this to our attention @chishui! We'll get a fix out for this when we get a chance. If you'd like, you can contribute this quick change and tag us in the PR when it's ready. |
chishui
added a commit
to chishui/opensearch-benchmark
that referenced
this issue
Apr 7, 2024
1 task
chishui
added a commit
to chishui/opensearch-benchmark
that referenced
this issue
Apr 9, 2024
chishui
added a commit
to chishui/opensearch-benchmark
that referenced
this issue
Apr 9, 2024
chishui
added a commit
to chishui/opensearch-benchmark
that referenced
this issue
Apr 9, 2024
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
chishui
added a commit
to chishui/opensearch-benchmark
that referenced
this issue
Apr 9, 2024
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
IanHoang
pushed a commit
that referenced
this issue
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
As described in this feature request in OpenSearch, I'm writing a python script to call opensearch-benchmark with different parameters to see which parameter could lead to better ingestion performance. I also want to use jupyter notebook to visualize the parameters in the notebook and we can let user to run process step by step.
However, opensearch-benchmark has a very strict restriction on dependency version and most of the versions are stale https://github.com/opensearch-project/opensearch-benchmark/blob/main/setup.py#L58. So the version conflict with jupyter's dependency, for example, opensearch-benchmark needs
jsonschema==3.1.1
, but jupyter notebook needsjsonschema>=4.18.0
(code)To Reproduce
pip install opensearch-benchmark
pip install notebook
opensearch-benchmark
, will see error message:Expected behavior
opensearch-benchmark can loosen the version requirement for its dependencies. Instead of using a fixed version, it can set a minimal supported version like "markupsafe>=2.0.1"
Logs
If applicable, add logs to help explain your problem.
More Context (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: