-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Create-Workload Enhancements] Rearchitect Create-Workload Feature #609
Merged
IanHoang
merged 20 commits into
opensearch-project:main
from
IanHoang:create-workload-v2-updated
Aug 9, 2024
Merged
[Create-Workload Enhancements] Rearchitect Create-Workload Feature #609
IanHoang
merged 20 commits into
opensearch-project:main
from
IanHoang:create-workload-v2-updated
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
…ousCorpusExtractor Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
…more apt Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
IanHoang
requested review from
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
August 5, 2024 15:36
IanHoang
changed the title
[Create-Workload] Rearchitect Create-Workload Feature
[Create-Workload Enhancements] Rearchitect Create-Workload Feature
Aug 5, 2024
3 tasks
gkamat
approved these changes
Aug 8, 2024
…ment based on feedback Signed-off-by: Ian Hoang <hoangia@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything remains the same + the changes based on feedback provided by Govind. Rebased latest main changes so that it picks up the latest IT updates.
Original PR: #586
Description
This PR refactors
create-workload
to make it extensible and improve development experience. The core functionality and logic of create-workload remains the same but the code structure has been reorganized.This has been tested with various indices and have compared the results of the original version with the results of these newest changes to ensure that there are no breaking changes.
Since this is reorganizing the foundation, the PR is quite lengthy. Going forward, changes will be smaller and incremental.
Issues Resolved
First steps in bridging gaps laid out in RFC #395. Specifically, this addresses the first step
Redesign the Create Workload feature
in the RFC.#587
Testing
End to End Testing
Created a workload and ran a test with the workload
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.