Refactored the OSB build system #632
Conversation
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
| cp -a opensearch-benchmark-git/* ./ | ||
| echo "Disable VERSION arg to enter docker build test mode" | ||
| PLATFORM=${{ matrix.platform }} | ||
| PLATFORM=`echo $PLATFORM | tr '/' '-'` | ||
| docker buildx build --platform ${{ matrix.platform }} --build-arg BUILD_ENV=testing --build-arg BUILD_DATE=`date -u +%Y-%m-%dT%H:%M:%SZ` -f "docker/Dockerfile" -t "osb/osb-$PLATFORM" -o type=docker . | ||
| docker images | grep "osb/osb-$PLATFORM" | ||
| tag=osb/osb-`echo ${{ matrix.platform }} | tr '/' '-'` | ||
| set -x |
There was a problem hiding this comment.
I understand your changes here but this change combined with the Dockerfile change basically cause the docker-build check to be inaccurate.
It will only check docker build based on merged code, instead of the commit sent with the PR. You can only detect issues once you merge the code, which defeat the purpose of PR check.
My original design was meant to have test mode testing the PR commit, while prod mode use the original pypi method. I think we should bring back the test mode, but only change prod mode to build from source instead of pulling from pypi, which should be the best of both approaches. Thanks.
There was a problem hiding this comment.
The updated changes should pull in the PR commit now.
gkamat
force-pushed
the
bld-fixes
branch
22 times, most recently
from
19b8175 to
6ebf085
Compare
gkamat
force-pushed
the
bld-fixes
branch
17 times, most recently
from
e82d2c6 to
bb0e874
Compare
|
Seems like docker-lint does not pass. |
gkamat
force-pushed
the
bld-fixes
branch
4 times, most recently
from
05757c5 to
7ad5d76
Compare
Signed-off-by: Govind Kamat <govkamat@amazon.com>
| ARG VERSION | ||
| ARG BUILD_ENV=production | ||
| # | ||
| # Stage 1: build packages and compile where needed |
There was a problem hiding this comment.
did we get any significant size reduction in final image by splitting into multi-stage? It is fairly simple dockerfile.
There was a problem hiding this comment.
See this comment:
#632 (comment)
There was a problem hiding this comment.
Size reduction is as noted in the link above. However, the objective of this PR is not so much the size reduction as it is to ensure the full release build process is run when changes are checked in and errors are caught at that time rather than during release. Also, the standalone development build has been revamped and simplified as well. Finally, the integ test pathway has been separated out too.
Signed-off-by: Govind Kamat <govkamat@amazon.com>
Description
Restructured the entire OSB build system, including standalone, Docker and via GitHub actions.
Testing
Tested out most combinations of the workflows above.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.