-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --all-tags copy of container image between different container registries #187
Add --all-tags copy of container image between different container registries #187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
============================================
+ Coverage 85.42% 85.50% +0.07%
Complexity 25 25
============================================
Files 74 75 +1
Lines 199 200 +1
Branches 11 11
============================================
+ Hits 170 171 +1
Misses 21 21
Partials 8 8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not clear (after reading related GH issue) what we are trying to achieve here? When you say recursive copy, it is just for one image or all images? For example we build os-ubuntu-1 and it pushed to dockerhub, enabling recursive copy will push to ECR too simultaneously?
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
4189c57
to
f724938
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
f724938
to
dde3349
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As understood, the recursive copy will only happen for tags between provided registries.
LGTM.
Apparently someone has pushed a change last week in the latest version Which solves: |
Will consider making that change to avoid issues like manually iterate through all the tags by gathering info from |
New commands:
|
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Hi @gaiksaya @rishabh6788 Also:
Thanks. |
Replied your comment @gaiksaya see my responses, Thanks. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
LGTM |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
All the comments have been adressed and reviewed again. Thanks.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
…gistries (#187) * Add recursive copy of container images repositories Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add boolean param and the tests Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add params requirements Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add new alltags Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update vars/copyContainer.groovy Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update vars/copyContainer.groovy Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add tests Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Bump version Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update vars/copyContainer.groovy Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> (cherry picked from commit 942749a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add --all-tags copy of container image between different container registries.
Either between docker hub / ecr or other registries.
Issues Resolved
Closes opensearch-project/opensearch-build#3386
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.