Add --all-tags copy of container image between different container registries

[peterzhuamazon]

Description

Add --all-tags copy of container image between different container registries.
Either between docker hub / ecr or other registries.

Issues Resolved

Closes opensearch-project/opensearch-build#3386

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #187 (fc1f315) into main (35f6aa9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head fc1f315 differs from pull request most recent head 1a5547f. Consider uploading reports for the commit 1a5547f to get more accurate results

@@             Coverage Diff              @@
##               main     #187      +/-   ##
============================================
+ Coverage     85.42%   85.50%   +0.07%     
  Complexity       25       25              
============================================
  Files            74       75       +1     
  Lines           199      200       +1     
  Branches         11       11              
============================================
+ Hits            170      171       +1     
  Misses           21       21              
  Partials          8        8              

Impacted Files	Coverage Δ
tests/jenkins/jobs/DockerCopy_Jenkinsfile	100.00% <ø> (ø)
tests/jenkins/jobs/DockerCopyAllTags_Jenkinsfile	100.00% <100.00%> (ø)

[gaiksaya]

I am still not clear (after reading related GH issue) what we are trying to achieve here? When you say recursive copy, it is just for one image or all images? For example we build os-ubuntu-1 and it pushed to dockerhub, enabling recursive copy will push to ECR too simultaneously?

[rishabh6788]

As understood, the recursive copy will only happen for tags between provided registries.
LGTM.

[peterzhuamazon]

Apparently someone has pushed a change last week in the latest version 0.15.x to allow all tags push during gcrane copy.

• Add --all-tags flag to crane cp google/go-containerregistry#1682

Which solves:

• feature request: (g)crane copy tags google/go-containerregistry#1355

[peterzhuamazon]

Will consider making that change to avoid issues like manually iterate through all the tags by gathering info from gcrane ls.

[peterzhuamazon]

New commands:

./crane <reg>/<repo>/<image> <reg>/<repo>/<image> --all-tags

[peterzhuamazon]

Pre-requisite:

• Add crane/krane as part of the executable binary in docker-builder image opensearch-build#3490

[peterzhuamazon]

Hi @gaiksaya @rishabh6788
Please review again as the current implementation is much cleaner.

Also:

1. Switch from gcrane to crane as --all-tags functionality is specifically added on crane.
2. gcrane is just a gcr specific crane variant that has better ls function, crane can do same thing and it is the source of truth. Similarly krane is more for the kube variant. See https://github.com/google/go-containerregistry#tools.
3. Make more logic in groovy to replace full-blown shell scripts.

Thanks.

[peterzhuamazon]

Replied your comment @gaiksaya see my responses, Thanks.
#187 (comment)

cc: @bbarani @rishabh6788 @prudhvigodithi .

[rishabh6788]

LGTM

All the comments have been adressed and reviewed again. Thanks.