Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle-check index mapping to make it generic and match old index fields #434

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

prudhvigodithi
Copy link
Collaborator

@prudhvigodithi prudhvigodithi commented Jun 3, 2024

Description

Update gradle-check index mapping to make it generic and match old index fields.

Issues Resolved

To ensure the OpenSearch Gradle Check Metrics visualizations does not break and load the new fields as the new indices are created.
Part of opensearch-project/opensearch-metrics#39

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…dex fields

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@rishabh6788
Copy link
Collaborator

Can you also update the new field corresponding to pr_description and commit_message?

@prudhvigodithi
Copy link
Collaborator Author

@rishabh6788 the pr_description was renamed to pull_request_title and today we dont have the commit_message field coming in. Also there no usage of pr_description in any visualizations at this point.

@rishabh6788
Copy link
Collaborator

Added new fields to gradle check workflow, we need to read the new env var pr_owner and pr_or_commit_description in the shell script and jenkinsfile.
opensearch-project/OpenSearch@4700be3

@prudhvigodithi
Copy link
Collaborator Author

Thanks the pull_request_owner already exists and we have the git_reference that links to the github with all the details, I dont think so we need the pr_or_commit_description that adds the commit message.

@prudhvigodithi prudhvigodithi merged commit 225bdd4 into opensearch-project:main Jun 6, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 13, 2024
…dex fields (#434)

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
(cherry picked from commit 225bdd4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants