Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboards-reports build.sh so it builds with dashboards #1278

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Dec 9, 2021

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Update dashboards-reports build.sh so it builds with dashboards

Issues Resolved

Relate to #870

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner December 9, 2021 18:15
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon mentioned this pull request Dec 9, 2021
30 tasks
@peterzhuamazon peterzhuamazon changed the title Update reports scheduler build.sh so it runs with dashboards Update dashboards-reports build.sh so it builds with dashboards Dec 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1278 (c971c1a) into main (760b5f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1278   +/-   ##
=========================================
  Coverage     94.15%   94.15%           
  Complexity       11       11           
=========================================
  Files           132      132           
  Lines          2924     2924           
  Branches         10       10           
=========================================
  Hits           2753     2753           
  Misses          161      161           
  Partials         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760b5f2...c971c1a. Read the comment docs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Can we add it to the default build script(s) too and fix #606?

@peterzhuamazon peterzhuamazon self-assigned this Dec 9, 2021
@peterzhuamazon peterzhuamazon merged commit 15cf4eb into opensearch-project:main Dec 9, 2021
@peterzhuamazon peterzhuamazon deleted the opensearch-fix-reports branch December 9, 2021 18:55
@peterzhuamazon
Copy link
Member Author

I like this! Can we add it to the default build script(s) too and fix #606?

@dblock this seems like a change needed to be added for every scripts in builds.
Is there any better mechanism you can think of that is similar to this?

Thanks.

@dblock
Copy link
Member

dblock commented Dec 9, 2021

I like this! Can we add it to the default build script(s) too and fix #606?

@dblock this seems like a change needed to be added for every scripts in builds. Is there any better mechanism you can think of that is similar to this?

We could provide a shared function or a shared .sh for this, but maybe we can just modify the scripts. Maybe someone from dashboards can take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants