-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboards-reports build.sh so it builds with dashboards #1278
Update dashboards-reports build.sh so it builds with dashboards #1278
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
=========================================
Coverage 94.15% 94.15%
Complexity 11 11
=========================================
Files 132 132
Lines 2924 2924
Branches 10 10
=========================================
Hits 2753 2753
Misses 161 161
Partials 10 10 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Can we add it to the default build script(s) too and fix #606?
We could provide a shared function or a shared .sh for this, but maybe we can just modify the scripts. Maybe someone from dashboards can take a look? |
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Update dashboards-reports build.sh so it builds with dashboards
Issues Resolved
Relate to #870
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.