Minor bugfix for signArtifacts.groovy #1437
Conversation
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
abhinavGupta16
requested review from
dblock,
peternied,
gaiksaya,
peterzhuamazon,
zelinh and
a team
Codecov Report
@@ Coverage Diff @@
## main #1437 +/- ##
============================================
- Coverage 94.45% 94.43% -0.03%
Complexity 11 11
============================================
Files 140 141 +1
Lines 3085 3071 -14
Branches 10 8 -2
============================================
- Hits 2914 2900 -14
Misses 164 164
Partials 7 7
Continue to review full report at Codecov.
|
vars/signArtifacts.groovy
Outdated
| @@ -30,8 +30,9 @@ void call(Map args = [:]) { | |||
| } | |||
|
|
|||
| void importPGPKey(){ | |||
| keyPath = "$WORKSPACE/opensearch.pgp" | |||
There was a problem hiding this comment.
Is this keyPath necessary? I think we are justing taking the gpg import out of the if bracket.
There was a problem hiding this comment.
I believe so, yes. I realized that the same path is being used at multiple places. So it is better to have in a variable. This makes it less error prone (for any changes in the path in future) and easy to follow.
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
I have added a test case for it. I have also changed the test case to be a unit test case only I believe we should do this for every jenkins job we have in the project. It would make sure the actual job test case fails if anyone makes changes to it. This should definitely make our jobs more robust against accidental changes. |
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
| @@ -0,0 +1,33 @@ | |||
| sign-standalone-artifacts.run() | |||
There was a problem hiding this comment.
Please move this file into the .../tests/data path with the other files
There was a problem hiding this comment.
data was being used to store dummy files that are required for tests. I have created a separate folder to hold regression txt files for jenkins job, tests/jenkins/jenkinsjob-regression-files. Let me know if the name of the dir works
Signed-off-by: Abhinav Gupta <abhng@amazon.com>
Signed-off-by: Abhinav Gupta abhng@amazon.com
Description
Currently, the pgp key for signing is only imported if the file is downloaded. We only need to download the file ones, however, we need to import the key if the file already exists or when we download the file.
Issues Resolved
pgp key failure will not happen for preexisting pgp key
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.