Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 1.3 manifest file for the Alerting and AlertingDashboards plugins #1732

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

AWSHurneyt
Copy link
Contributor

Signed-off-by: AWSHurneyt hurneyt@amazon.com

Description

Updated 1.3 manifest file for the Alerting and AlertingDashboards plugins

Issues Resolved

opensearch-project/alerting#314
opensearch-project/alerting-dashboards-plugin#179

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…gins.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1732 (8de0db4) into main (d015816) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1732   +/-   ##
=========================================
  Coverage     94.78%   94.78%           
  Complexity       17       17           
=========================================
  Files           169      169           
  Lines          3525     3525           
  Branches         26       26           
=========================================
  Hits           3341     3341           
  Misses          181      181           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d015816...8de0db4. Read the comment docs.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review March 9, 2022 20:48
@AWSHurneyt AWSHurneyt requested a review from a team as a code owner March 9, 2022 20:48
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually nvm here. I think we should use "" since it's more widely used in our manifests.

@AWSHurneyt
Copy link
Contributor Author

@zelinh I do not seem to have the necessary permissions to merge this PR. Is that intended, or should I seek the necessary permissions?

@zelinh zelinh merged commit 0079ef1 into opensearch-project:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants