Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD][OSD] Support version qualifier #1836

Merged
merged 5 commits into from
Mar 29, 2022

Commits on Mar 29, 2022

  1. [BUILD][OSD] Support version qualifier

    Support version qualifier builds for OpenSearch Dashboards and
    OpenSearch Dashboards Plugins.
    
    This will create a zip for plugins with the OpenSearch Dashboards
    version + qualifier. But the version of the plugin will remain the
    same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
    will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
    the version check needed to be modified a little to ensure that it can
    get the version + qualifier and the default version of the plugin.
    
    Updated for plugins as well.
    
    Was able to successfully build and connect OSD 1.3.0-alpha1 to
    the release version of OS 1.3.0.
    
    Issue resolved:
    opensearch-project/OpenSearch-Dashboards#1340
    
    Issue partially resolved:
    opensearch-project#1632
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c01c65d View commit details
    Browse the repository at this point in the history
  2. dont use set

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    277530a View commit details
    Browse the repository at this point in the history
  3. trailing space

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c1d6f11 View commit details
    Browse the repository at this point in the history
  4. Change plugin check to be min version

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    5e3eeb9 View commit details
    Browse the repository at this point in the history
  5. Remove support of plugin x.y.z.0 with OSD x.y.z-qualifier

    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    a8391a2 View commit details
    Browse the repository at this point in the history