Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --component support for jenkins build pipelines (From PR [2095]) #2100

Merged
merged 2 commits into from
May 10, 2022

Conversation

prudhvigodithi
Copy link
Collaborator

@prudhvigodithi prudhvigodithi commented May 7, 2022

Description

Add --component support for jenkins build pipelines, including tests for shared library buildManifest
(From PR #2095 added tests)

Issues Resolved

#2091

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi requested a review from a team as a code owner May 7, 2022 00:04
@prudhvigodithi prudhvigodithi changed the title Add --component support for jenkins build pipelines (From PR [2095](https://github.com/opensearch-project/opensearch-build/pull/2095)) Add --component support for jenkins build pipelines (From PR [2095]) May 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #2100 (9c0a263) into main (10fef48) will increase coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 9c0a263 differs from pull request most recent head 97d63c8. Consider uploading reports for the commit 97d63c8 to get more accurate results

@@             Coverage Diff              @@
##               main    #2100      +/-   ##
============================================
+ Coverage     94.23%   94.64%   +0.40%     
============================================
  Files           198      152      -46     
  Lines          3902     3732     -170     
  Branches         29       19      -10     
============================================
- Hits           3677     3532     -145     
+ Misses          219      200      -19     
+ Partials          6        0       -6     
Impacted Files Coverage Δ
tests/jenkins/jobs/RunBwcTestScript_Jenkinsfile
tests/jenkins/jobs/RunIntegTestScript_Jenkinsfile
src/jenkins/InputManifest.groovy
tests/jenkins/jobs/DownloadFromS3_Jenkinsfile
...PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile
tests/jenkins/jobs/PublishNotification_Jenkinsfile
...sts/jenkins/jobs/ArchiveAssembleUpload_Jenkinsfile
tests/jenkins/jobs/UploadTestResults_Jenkinsfile
tests/jenkins/jobs/DetectDockerImage_Jenkinsfile
tests/jenkins/jobs/PromoteArtifacts_Jenkinsfile
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fef48...97d63c8. Read the comment docs.

Signed-off-by: pgodithi <pgodithi@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The test added only tests with a component name, but doesn't test without. Add a test without the component name.
  2. Looks like we may be missing tests for other parameters, consider expanding (1).
  3. Nit: I would remove the majority of the boilerplate in tests/jenkins/jobs/buildShManifest_Jenkinsfile that's not necessary to the test, but NBD.
  4. Auto-format buildShManifest_Jenkinsfile, please.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh
Copy link
Member

zelinh commented May 9, 2022

  1. The test added only tests with a component name, but doesn't test without. Add a test without the component name.
  2. Looks like we may be missing tests for other parameters, consider expanding (1).
  3. Nit: I would remove the majority of the boilerplate in tests/jenkins/jobs/buildShManifest_Jenkinsfile that's not necessary to the test, but NBD.
  4. Auto-format buildShManifest_Jenkinsfile, please.

I committed some changes with more test cases and reformat the tests. Please help review this.

@dblock dblock merged commit fd028ed into opensearch-project:main May 10, 2022
@dblock
Copy link
Member

dblock commented May 10, 2022

Merged. @zelinh @peterzhuamazon you can kick off the --component OpenSearch build. I do think we need to document this as a step somewhere, but I don't know where and didn't want to hold this PR any further back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants