-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --component support for jenkins build pipelines (From PR [2095]) #2100
Add --component support for jenkins build pipelines (From PR [2095]) #2100
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2100 +/- ##
============================================
+ Coverage 94.23% 94.64% +0.40%
============================================
Files 198 152 -46
Lines 3902 3732 -170
Branches 29 19 -10
============================================
- Hits 3677 3532 -145
+ Misses 219 200 -19
+ Partials 6 0 -6 Continue to review full report at Codecov.
|
Signed-off-by: pgodithi <pgodithi@amazon.com>
8f977e0
to
c37098d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The test added only tests with a component name, but doesn't test without. Add a test without the component name.
- Looks like we may be missing tests for other parameters, consider expanding (1).
- Nit: I would remove the majority of the boilerplate in tests/jenkins/jobs/buildShManifest_Jenkinsfile that's not necessary to the test, but NBD.
- Auto-format buildShManifest_Jenkinsfile, please.
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
I committed some changes with more test cases and reformat the tests. Please help review this. |
Merged. @zelinh @peterzhuamazon you can kick off the |
Description
Add --component support for jenkins build pipelines, including tests for shared library
buildManifest
(From PR #2095 added tests)
Issues Resolved
#2091
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.