-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Min Artifacts Building on Jenkins #2483
Add Windows Min Artifacts Building on Jenkins #2483
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2483 +/- ##
=============================================
+ Coverage 94.63% 100.00% +5.36%
=============================================
Files 213 6 -207
Lines 4324 105 -4219
Branches 29 19 -10
=============================================
- Hits 4092 105 -3987
+ Misses 226 0 -226
+ Partials 6 0 -6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine.
I think we should raise the bar on the retry implementation and take a separate function from https://stackoverflow.com/questions/42521549/retry-function-in-python for example. Put it into system....
and write a test for it.
Hi @dblock I agree with many points you raised but not agree with putting the retries into another function. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Description
Add Windows Min Artifacts Building on Jenkins
Issues Resolved
#2306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.