Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve install demo config access issue and use 1.0.2 lib to fix minUpload for Windows #2721

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Resolve install demo config access issue and use 1.0.2 lib to fix minUpload for Windows

Issues Resolved

#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added the bug Something isn't working label Oct 11, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner October 11, 2022 21:45
@peterzhuamazon peterzhuamazon self-assigned this Oct 11, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #2721 (5a96c52) into main (7a4f4dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2721   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         156      156           
  Lines        4208     4208           
=======================================
  Hits         3960     3960           
  Misses        248      248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon
Copy link
Member Author

The groovy test is unrelated and is currently being investigated in opensearch-project/opensearch-build-libraries#7.

@peterzhuamazon peterzhuamazon merged commit a12827a into opensearch-project:main Oct 11, 2022
@peterzhuamazon peterzhuamazon deleted the windows-security-fix branch October 11, 2022 23:07
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
…Upload for Windows (opensearch-project#2721)

* Test Again

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Test 1.0.2 lib

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update check for build 2.4.0 to be every 60min

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Monu Singh <msnghgw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants