Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows integTest to OpenSearch Clusters #2761

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Add windows integTest to OpenSearch Clusters

Issues Resolved

#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon and others added 3 commits October 13, 2022 22:50
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor the command line if.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Oct 19, 2022

After talking to DB seems like it is better to for later improvements:

Add a product selector, a product class, 2 product subclasses to run product specific start up cmd.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Hi @dblock please review again as I have separate to two classes to test OS and OSD in zip.
Thanks.

@dblock dblock merged commit 35bb902 into opensearch-project:main Oct 19, 2022
@gaiksaya
Copy link
Member

@peterzhuamazon peterzhuamazon deleted the opensearch-windows-integtest-1 branch October 19, 2022 19:51
@peterzhuamazon
Copy link
Member Author

monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
* Add new setups

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add windows integTest to OpenSearch Clusters

Signed-off-by: Your Name <you@example.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Restructure zip tests

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Your Name <you@example.com>
Co-authored-by: Your Name <you@example.com>
Signed-off-by: Monu Singh <msnghgw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants