Adding OSD in the distribution build pipeline with build script using volta to install nodejs dependencies

[peterzhuamazon]

Description

Make tweaks to dashboards plugin build script to support windows

Issues Resolved

#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #2841 (1417f7a) into main (3eea73a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2841   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         158      158           
  Lines        4373     4373           
=======================================
  Hits         4096     4096           
  Misses        277      277           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[prudhvigodithi]

@peterzhuamazon are we going to 2.3.1 ?
@bbarani

[peterzhuamazon]

We are planning 2.3.1 if needed thus still running the builds.

[prudhvigodithi]

Hey @peterzhuamazon can the volta install be part of the agent, meaning can we pre-bake those packages to the agent?

[peterzhuamazon]

Hey @peterzhuamazon can the volta install be part of the agent, meaning can we pre-bake those packages to the agent?

We already did that but just like container there are issues:

1. Volta, just like NVM is using symlink during installation, which does not preserve after baking into an AMI. The better thing on Volta than NVM is that Volta is using a fixed path and automatically replace binaries on the fly during the build.

2. A little confusion you may have is Volta does not have a use command, thus the volta install command here is simply switching the version that we already installed. Remember this image requires to have multiple versions of nodejs so 1.x/2.x/3.x can all be built.

3. Install on the fly also allow us to reduce the number of AMIs to be generated just because a simple nodejs version change, which requires a redeploy of Jenkins to consume the new AMI.

Thanks.

[tianleh]

Have we tested the change in a Jenkins job?

[peterzhuamazon]

Have we tested the change in a Jenkins job?

Yes we have tested the PR with 2.4.0 builds:

2022-11-03 01:50:01 INFO     Installed plugins: ['alertingDashboards', 'anomalyDetectionDashboards', 'customImportMapDashboards', 'ganttChartDashboards', 'indexManagementDashboards', 'notificationsDashboards', 'observabilityDashboards', 'queryWorkbenchDashboards', 'reportsDashboards', 'searchRelevanceDashboards', 'securityAnalyticsDashboards', 'securityDashboards']

2022-11-03 01:54:18 INFO     Published C:\Users\Administrator\jenkins\workspace\zhujiaxi\bundle-build-zhujiaxi\zip\dist\opensearch-dashboards\opensearch-dashboards-2.4.0-windows-x64.zip.