Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert set output command #2903

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

gaiksaya
Copy link
Member

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

Needs some more testing to make it work right. Reverting for now

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya requested a review from a team as a code owner November 15, 2022 20:26
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #2903 (3c40c73) into main (7dc560e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2903   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         158      158           
  Lines        4414     4414           
=======================================
  Hits         4137     4137           
  Misses        277      277           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaiksaya
Copy link
Member Author

Merging this PR has github actions is stuck to get a runner up. Unrelated check remaining.

@gaiksaya gaiksaya merged commit 67b7630 into opensearch-project:main Nov 15, 2022
@gaiksaya gaiksaya deleted the revert-echo branch November 15, 2022 21:27
mnin added a commit to graylog-labs/opensearch-build that referenced this pull request Nov 16, 2022
# By Peter Zhu (8) and others
# Via GitHub
* upstream/main: (24 commits)
  Updated manifests. (opensearch-project#2894)
  Update ref for 2.4.0 with tags (opensearch-project#2906)
  Fix status syntax for gradle check (opensearch-project#2907)
  Add the consolidated release notes for 2.4.0 release (opensearch-project#2887)
  Revert set output command (opensearch-project#2903)
  Fix status code for gradle check with retry (opensearch-project#2902)
  Upgrade actions and remove deprecated set ouput commands (opensearch-project#2901)
  Update opensearch-2.4.0.yml (opensearch-project#2896)
  Resolve Window IntegTest copy and startup issues (opensearch-project#2892)
  Update IM ref to include fix (opensearch-project#2890)
  Fix manifest workflow failure (opensearch-project#2889)
  Install twine on clients image (opensearch-project#2884)
  Freeze the ref with commit ID (opensearch-project#2882)
  Add latest url update toggle on distribution workflows (opensearch-project#2881)
  Update promoteArtifacts to support win/zip and add timer for gradle check windows (opensearch-project#2869)
  Fix signing the artifacts for .asc signatures (opensearch-project#2850)
  Update the ref with 2.4 branch for OSD. (opensearch-project#2855)
  Update the OSD manifest with commit ID (opensearch-project#2862)
  Add gradle check support for windows agent (opensearch-project#2860)
  Add default copy for opensearch-dashboards yml and docker entrypoint (opensearch-project#2861)
  ...

# Conflicts:
#	scripts/components/OpenSearch-Dashboards/install.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants