Fix missing local cluster logs when running integration test #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3453 +/- ##
==========================================
- Coverage 91.74% 91.72% -0.03%
==========================================
Files 172 172
Lines 4991 4991
==========================================
- Hits 4579 4578 -1
- Misses 412 413 +1
|
peterzhuamazon
approved these changes
Apr 29, 2023
zelinh
commented
Apr 29, 2023
There was a problem hiding this comment.
On my tests locally, the integration tests are able to run either by each component or sequentially with all components with all missing logs present now.
Reproducible with command: ./test.sh integ-test manifests/2.7.0/opensearch-2.7.0-test.yml -p opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.7.0/7771/linux/x64/tar
|
You should be writing tests for these, because it fixes a real problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing local cluster logs when running integration test.
Currently the local cluster is wiped out before the logs recorded. Rearrange the logics and record the logs after remove everything including the local cluster logs.
This is an alternative way of #3404 to resolve the issue.
Issues Resolved
#3382
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.