Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS Upgrade] Make manifests / jenkinsfile use new node in #3552 #3558 #3560

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 25, 2023

Description

[NodeJS Upgrade] Make manifests / jenkinsfile use new node in #3552 #3558

Issues Resolved

#3434
#1563

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Please make sure not merge until those images built.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #3560 (14f4fb4) into main (e33c997) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3560   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         181      181           
  Lines        5369     5369           
=======================================
  Hits         4912     4912           
  Misses        457      457           

@peterzhuamazon peterzhuamazon merged commit 78f9343 into opensearch-project:main May 25, 2023
@peterzhuamazon peterzhuamazon deleted the node16_manfiest_jenkinsfile branch May 25, 2023 02:35
@peterzhuamazon peterzhuamazon changed the title Make manifests / jenkinsfile use new node in #3552 #3558 [NodeJS Upgrade] Make manifests / jenkinsfile use new node in #3552 #3558 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants