edit comment for minimum_master_nodes config #4316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 10000-ki <10000ki6472@gmail.com>
10000-ki
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 189 189
Lines 6146 6146
=======================================
Hits 5604 5604
Misses 542 542 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
Jan 3, 2024
|
LGTM, adding @peterzhuamazon @gaiksaya |
|
@peterzhuamazon hi! |
|
Thanks for opening the PR @10000-ki but I am a bit confused here: I think that check is only to see if (node.getVersion().onOrAfter("7.0.0")), not related to 1.x or 2.x as the change related to that is: Thanks. |
peterzhuamazon
requested changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/opensearch-project/OpenSearch/blob/6a01d2f95b7e98c601949a58b92b91e3e4022e17/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchCluster.java#L410
discovery.zen.minimum_master_nodesis only valid for opensearch 1.x.xI think it could confuse the user, so I improved the comment.
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.