-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding components to 1.3.15 and update to hourly build #4477
Conversation
…urly Signed-off-by: Jeff Lu <chunglu@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4477 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 192 192
Lines 6292 6292
=======================================
Hits 5801 5801
Misses 491 491 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jeff Lu <chunglu@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you have all version bumped to 1.3.15 for plugin repo. For some plugins, they need dependencies plugins to be built for their CI to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add depends_on
to plugins and update the schema version to enable incremental build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, @zelinh , let me check those plugins that haven't bump to 1.3.15 yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @zelinh , I change to have only those essential components for now .. place holder PR after opensearch-project/OpenSearch#12243 is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core build was successful and AUTOCUT issue was resolved. https://build.ci.opensearch.org/job/distribution-build-opensearch/9492/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending on opensearch-project/common-utils#575
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opensearch-project/common-utils#575 has been merged
Signed-off-by: Jeff Lu <chunglu@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we normally added OSD plugins after building their backend plugins but it should be fine. Thanks @jordarlu
Adding components to 1.3.15 manifest and update the build to be hourly
Description
Issues Resolved
part of #4294
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.