Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding components to 1.3.15 and update to hourly build #4477

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

jordarlu
Copy link
Contributor

@jordarlu jordarlu commented Feb 26, 2024

Adding components to 1.3.15 manifest and update the build to be hourly

Description

  1. Adding essential components to 1.3.15 OpenSearch manifest: common-utils + job-scheduler + security
  2. Adding all components to 1.3.15 OpenSearch Dashboards manifest
  3. Updating 1.3.15 to hourly build for both OpenSearch and OpenSearch Dashboards
  4. Updating maven publish 1.3.x to use manifest 1.3.15

Issues Resolved

part of #4294

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…urly

Signed-off-by: Jeff Lu <chunglu@amazon.com>
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (e0ff942) to head (92ae371).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4477   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         192      192           
  Lines        6292     6292           
=======================================
  Hits         5801     5801           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jeff Lu <chunglu@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you have all version bumped to 1.3.15 for plugin repo. For some plugins, they need dependencies plugins to be built for their CI to pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add depends_on to plugins and update the schema version to enable incremental build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, @zelinh , let me check those plugins that haven't bump to 1.3.15 yet...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @zelinh , I change to have only those essential components for now .. place holder PR after opensearch-project/OpenSearch#12243 is resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core build was successful and AUTOCUT issue was resolved. https://build.ci.opensearch.org/job/distribution-build-opensearch/9492/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Jeff Lu <chunglu@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we normally added OSD plugins after building their backend plugins but it should be fine. Thanks @jordarlu

@jordarlu jordarlu merged commit b480a00 into opensearch-project:main Feb 28, 2024
12 checks passed
@jordarlu jordarlu deleted the 1_3_15_essential branch February 28, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants