Add new jenkins job for benchmarking pull request #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4831 +/- ##
==========================================
+ Coverage 92.05% 92.07% +0.02%
==========================================
Files 193 193
Lines 6416 6445 +29
==========================================
+ Hits 5906 5934 +28
- Misses 510 511 +1 ☔ View full report in Codecov by Sentry. |
rishabh6788
requested review from
dblock,
peterzhuamazon,
gaiksaya,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
| [key: 'CAPTURE_NODE_STAT', value: '$.CAPTURE_NODE_STAT'], | ||
| [key: 'TELEMETRY_PARAMS', value: '$.TELEMETRY_PARAMS'] | ||
| ], | ||
| tokenCredentialId: 'jenkins-pr-benchmark-generic-webhook-token', |
There was a problem hiding this comment.
Token is already created for this job?
There was a problem hiding this comment.
No, will create a PR in opensearch-ci repo for this.
gaiksaya
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Couple of questions:
- Can we repurpose or make the current benchmark test generic enough to handle PR as well instead of maintaining an identical version?
- Little confused with overall workflow. I understand the PR is the trigger but it is on every commit or synchronize or something else?
- If not PR what is the other trigger
- From security point of view, can you please list how to avoid multi-runs for same PR?
| if (currentBuild.rawBuild.getCauses().toString().contains("GenericCause")) { | ||
| currentBuild.description = "Benchmark initiated by PR:${pull_request} on ${repository}" | ||
| } | ||
| else { |
There was a problem hiding this comment.
If not pull request what is the other cause? Ad-hoc run?
There was a problem hiding this comment.
Should the cause string be differed accordingly then?
There was a problem hiding this comment.
Yes, it will be set by Jenkins I believe.
something like Started by user <user-id>.
There was a problem hiding this comment.
Okay got it. The cause string only applies if we use generic trigger plugin
|
Signed-off-by: Rishabh Singh <sngri@amazon.com>
This was referenced Jul 10, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
--results-fileflag to opensearch-benchmark command to write the final markdown format output to a file. This file content will be read and published to PR comment in jenkinsfile.benchmark-test.jenkinsfileIssues Resolved
#4804
opensearch-project/OpenSearch#14553
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.