-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboards-flow-framework to build repo #4852
Add dashboards-flow-framework to build repo #4852
Conversation
Signed-off-by: saimedhi <saimedhi@amazon.com>
LGTM - @prudhvigodithi regarding this plugin, it is not in a fully stable state or have integ tests configured yet; is there any concern in onboarding to the main/3.0 builds? Additionally, is there anything we need to track to automatically onboard to 2.17 release when that is kickstarted and the manifests are available? We do not plan to include this in 2.16. |
|
LGTM, please onboard to |
Would need to open a new PR to add to 2.17 once 2.16 is release. Thanks. |
Also note if your plugin has a new feature flag, experimental flag, or similar you need to add them to docker entrypoint. Will check then. |
Hi @saimedhi Can you please resolve the merge conflict? |
Signed-off-by: Divya Madala <113469545+Divyaasm@users.noreply.github.com>
@peterzhuamazon Looks like there is a bug with manifest-ci-check. It won't run the runs for updated commits. Just the initial ones. |
Description
Add dashboards-flow-framework to build repo
Issues Resolved
Related to #4851
dashboards-flow-framework plugin is expected to release with OpenSearch 2.17.
In the manifests, 2.17 is not yet added. So, after that gets added need to add below code to it.
Plugin is not yet stable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.