Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboards-flow-framework to build repo #4852

Merged

Conversation

saimedhi
Copy link
Contributor

@saimedhi saimedhi commented Jul 16, 2024

Description

Add dashboards-flow-framework to build repo

Issues Resolved

Related to #4851

dashboards-flow-framework plugin is expected to release with OpenSearch 2.17.

In the manifests, 2.17 is not yet added. So, after that gets added need to add below code to it.

 - name: flowFrameworkDashboards
    repository: https://github.com/opensearch-project/dashboards-flow-framework.git
    ref: 2.x

Plugin is not yet stable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
@ohltyler
Copy link
Member

LGTM - @prudhvigodithi regarding this plugin, it is not in a fully stable state or have integ tests configured yet; is there any concern in onboarding to the main/3.0 builds? Additionally, is there anything we need to track to automatically onboard to 2.17 release when that is kickstarted and the manifests are available? We do not plan to include this in 2.16.

@saimedhi
Copy link
Contributor Author

LGTM - @prudhvigodithi regarding this plugin, it is not in a fully stable state or have integ tests configured yet; is there any concern in onboarding to the main/3.0 builds? Additionally, is there anything we need to track to automatically onboard to 2.17 release when that is kickstarted and the manifests are available? We do not plan to include this in 2.16.

@prudhvigodithi,

@prudhvigodithi
Copy link
Collaborator

LGTM, please onboard to manifests/3.0.0/opensearch-dashboards-3.0.0-test.yml as well.
Thanks
Adding @peterzhuamazon @gaiksaya

@peterzhuamazon
Copy link
Member

Would need to open a new PR to add to 2.17 once 2.16 is release.

Thanks.

@peterzhuamazon
Copy link
Member

Also note if your plugin has a new feature flag, experimental flag, or similar you need to add them to docker entrypoint.
But that is another story entirely.

Will check then.

@gaiksaya
Copy link
Member

Hi @saimedhi

Can you please resolve the merge conflict?

Signed-off-by: Divya Madala <113469545+Divyaasm@users.noreply.github.com>
@Divyaasm
Copy link
Collaborator

Hi @saimedhi

Can you please resolve the merge conflict?

Done! We can merge once the checks pass @gaiksaya

@gaiksaya
Copy link
Member

@peterzhuamazon Looks like there is a bug with manifest-ci-check. It won't run the runs for updated commits. Just the initial ones.

@gaiksaya gaiksaya merged commit 669d5de into opensearch-project:main Jul 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants