Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid checking outdated branches during manifest update #4867

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 19, 2024

Description

Avoid checking outdated branches during manifest update

Issues Resolved

avast/gradle-docker-compose-plugin#446
#4870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do we want to add some test cases for these changes?

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jul 19, 2024

This looks good to me. Do we want to add some test cases for these changes?

Added now, thanks.

@peterzhuamazon
Copy link
Member Author

Test locally:

2024-07-19 20:10:17 INFO     Known versions: ['1.0.0', '1.0.1', '1.1.0', '1.1.1', '1.2.0', '1.2.1', '1.2.2', '1.2.3', '1.2.4', '1.2.5', '1.3.0', '1.3.1', '1.3.2', '1.3.3', '1.3.4', '1.3.5', '1.3.6', '1.3.7', '1.3.8', '1.3.9', '1.3.10', '1.3.11', '1.3.12', '1.3.13', '1.3.14', '1.3.15', '1.3.16', '1.3.17', '1.3.18', '1.4.0', '2.0.0', '2.0.1', '2.0.2', '2.1.0', '2.1.1', '2.2.0', '2.2.1', '2.2.2', '2.3.0', '2.3.1', '2.4.0', '2.4.1', '2.4.2', '2.5.0', '2.5.1', '2.6.0', '2.6.1', '2.7.0', '2.7.1', '2.8.0', '2.8.1', '2.9.0', '2.9.1', '2.10.0', '2.10.1', '2.11.0', '2.11.1', '2.11.2', '2.12.0', '2.12.1', '2.13.0', '2.13.1', '2.14.0', '2.14.1', '2.15.0', '2.15.1', '2.16.0', '3.0.0']
2024-07-19 20:10:17 INFO     Checking out components into /tmp/tmpjyhg7jik
2024-07-19 20:10:18 INFO     Checking OpenSearch ['1.3', '1.x', '2.0', '2.1', '2.10', '2.11', '2.12', '2.13', '2.14', '2.15', '2.2', '2.3', '2.4', '2.5', '2.5-transfer', '2.6', '2.7', '2.8', '2.9', '2.x', 'main'] branches
2024-07-19 20:10:18 INFO     Ignoring OpenSearch ['1.0', '1.1', '1.2'] branches as they are outdated
2024-07-19 20:10:18 INFO     Executing "git init" in /tmp/tmpjyhg7jik/OpenSearch/1.3
2024-07-19 20:10:18 INFO     Executing "git remote add origin https://github.com/opensearch-project/OpenSearch.git" in /tmp/tmpjyhg7jik/OpenSearch/1.3
2024-07-19 20:10:18 INFO     Executing "git fetch --depth 1 origin 1.3" in /tmp/tmpjyhg7jik/OpenSearch/1.3
2024-07-19 20:10:22 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmpjyhg7jik/OpenSearch/1.3
2024-07-19 20:10:23 INFO     Executing "git rev-parse HEAD" in /tmp/tmpjyhg7jik/OpenSearch/1.3
2024-07-19 20:10:23 INFO     Checked out https://github.com/opensearch-project/OpenSearch.git@1.3 into /tmp/tmpjyhg7jik/OpenSearch/1.3 at 338255f1217356766b459cadf6b0aec25267eefc
2024-07-19 20:10:23 INFO     Executing "./gradlew properties -Dbuild.snapshot=false" in /tmp/tmpjyhg7jik/OpenSearch/1.3

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterzhuamazon peterzhuamazon merged commit 049851d into opensearch-project:main Jul 19, 2024
10 checks passed
@peterzhuamazon peterzhuamazon deleted the avoid-checking-outdated-manifests branch July 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants