Skipping integTest for rpm and deb distribution for CCR #4905
Conversation
Signed-off-by: nandan <nandnkum@amazon.com>
nandnkum
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
There was a problem hiding this comment.
Hi @nandnkum ,
Add some comments.
Once you resolve those I will check if we need test cases update. Thanks.
| @@ -172,6 +172,11 @@ pipeline { | |||
| echo "Skipping tests for ${component_check} as is not present in the provided build manifest." | |||
| componentList -= component_check | |||
| } | |||
| // Skipping integTest for cross-cluster-replication component when running on deb and rpm distribution | |||
There was a problem hiding this comment.
Please also add TODO to this comment and link the corresponding issue.
Eventually we would need to fix this as this change is temporary.
Thanks.
| @@ -172,6 +172,11 @@ pipeline { | |||
| echo "Skipping tests for ${component_check} as is not present in the provided build manifest." | |||
| componentList -= component_check | |||
| } | |||
| // Skipping integTest for cross-cluster-replication component when running on deb and rpm distribution | |||
| if ((distribution.equals('rpm') || distribution.equals('deb')) && component_check == 'cross-cluster-replication') { | |||
There was a problem hiding this comment.
Can we keep consistent on using equals vs ==.
…t when running on deb and rpm distribution. Signed-off-by: nandan <nandnkum@amazon.com>
There was a problem hiding this comment.
Thanks @nandnkum .
cc: @prudhvigodithi whether we need to merge this next week after 2.16.0 is out. (convert back to draft just in case)
Or we can test earlier on this. Thanks.
|
Please wait until 2.16.0 is out. If the pipeline breaks due to syntax or other issues, release process might be stuck. Also @nandnkum Is there no plan to support CCR on these distributions in the long term? |
I see! Trying to think of a better way to skip for specific use-cases (like this one) instead of adding conditional statements. @peterzhuamazon @prudhvigodithi Do you think we can add something in test-manifest to handle this? |
We can, but that would take a bit more time. |
|
Able to skip, tho not perfect, we should look into directly making the call in python code later. Thanks. |
Skipping integTest for cross-cluster-replication component when running on deb and rpm distribution.