Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade library version to fix CVEs #4984

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Aug 29, 2024

Description

Upgrade library version to fix CVEs

Issues Resolved

#4979

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh
Copy link
Member Author

zelinh commented Aug 29, 2024

Seems like upgrading spring-security-web explicitly will cause gradle issue. Looking into it.

@zelinh
Copy link
Member Author

zelinh commented Aug 29, 2024

After researching, we can't upgrade spring libraries without upgrading jenkins core version and potential JDK upgrade. Explicitly upgrading will cause compatibility issue. Removing that line.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@Divyaasm
Copy link
Collaborator

The version of shhdcore plugin used in prod jenkins is 2.12.1-101.v85b_e08b_780dd. @zelinh can you update the version to use 2.12.1. Hope we should be good with the PR
@prudhvigodithi WDYT?

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh
Copy link
Member Author

zelinh commented Aug 30, 2024

2.12.1-101.v85b_e08b_780dd

The version of shhdcore plugin used in prod jenkins is 2.12.1-101.v85b_e08b_780dd. @zelinh can you update the version to use 2.12.1. Hope we should be good with the PR @prudhvigodithi WDYT?

Updated the version in the latest commit. Thanks.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (f355251) to head (959084a).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4984      +/-   ##
==========================================
+ Coverage   92.17%   92.20%   +0.02%     
==========================================
  Files         197      197              
  Lines        6634     6656      +22     
==========================================
+ Hits         6115     6137      +22     
  Misses        519      519              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon merged commit 991fcbd into opensearch-project:main Sep 3, 2024
11 of 12 checks passed
@peterzhuamazon peterzhuamazon deleted the fix-cve branch September 3, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

CVE-2024-41909 (Medium) detected in sshd-common-2.9.2.jar, sshd-core-2.9.2.jar
3 participants