Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the clients release docker image to AlmaLinux 8 #4985

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Aug 30, 2024

Description

Update the clients release docker image to AlmaLinux 8.

Allows upgrading to .NET SDK 8.0. opensearch-net now uses .NET SDK 8.0 to build, but current image only has 6.0, leading to a release failure. CentOS 7 is not supported by Microsoft anymore and so .NET 8.0 is unavailable without upgrading.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Allows upgrading to .NET SDK 8.0

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the update/clients-release-docker-image branch from e9d55ae to f95c591 Compare August 30, 2024 01:51
@peterzhuamazon
Copy link
Member

Taking a look.

@gaiksaya
Copy link
Member

gaiksaya commented Sep 3, 2024

How about keep both files under current? As other clients are using the current ones. You can override the default one by new image using https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L15

@peterzhuamazon
Copy link
Member

How about keep both files under current? As other clients are using the current ones. You can override the default one by new image using https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L15

I am ok to actually start migrating to alma8 for other clients now.
As CentOS7 is already deprecated per our announcement.
Also it is not easy to maintain it overtime due to not having updated pkgs everywhere.

The CentOS7 image is on dockerhub already so we can move the dockerfile to legacy to prevent new builds and can start the migrations as needed.
WDYT @gaiksaya ?

Thanks.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Xtansia thanks for the PR here.

The file has been altered a bit compares to the original dockerfile.

Could you please take a look on it? Thanks.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@peterzhuamazon
Copy link
Member

Thanks @Xtansia !

@peterzhuamazon peterzhuamazon merged commit bd481f0 into opensearch-project:main Sep 4, 2024
12 checks passed
@peterzhuamazon
Copy link
Member

Will build image.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 4, 2024

@Xtansia Xtansia deleted the update/clients-release-docker-image branch September 4, 2024 20:33
@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants