Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom start commands and options to resolve GHA issues #5189

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Enable custom start commands and options to resolve GHA issues

Issues Resolved

#5178

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@@ -6,6 +6,8 @@ on: [push, pull_request]
jobs:
Get-CI-Image-Tag:
uses: ./.github/workflows/get-ci-image-tag.yml
with:
product: opensearch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We add this to opt out the OSD python tests?

Copy link
Member Author

@peterzhuamazon peterzhuamazon Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to do with OSD python test it is just more consistent to find the AL2 image we are retrieving.

@peterzhuamazon peterzhuamazon merged commit 25f2607 into opensearch-project:main Nov 15, 2024
11 checks passed
@peterzhuamazon peterzhuamazon deleted the update-nodejs-compat branch November 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants