[Backport main] feat: freeze browser version to 112 #1417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: freeze browser version Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 03548a6)
opensearch-trigger-bot
bot
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
SuZhou-Joe
approved these changes
Jun 18, 2024
|
The flaky tests in a known issue in main. |
wanglam
reviewed
Jun 18, 2024
| @@ -72,7 +72,7 @@ jobs: | |||
| uses: ./.github/workflows/release-e2e-workflow-template.yml | |||
| with: | |||
| test-name: "osd:ciGroup${{ matrix.ciGroup }}" | |||
| test-command: env CYPRESS_NO_COMMAND_LOG=1 CYPRESS_ML_COMMONS_DASHBOARDS_ENABLED=true CYPRESS_VISBUILDER_ENABLED=true CYPRESS_DATASOURCE_MANAGEMENT_ENABLED=true yarn cypress:run-with-security --browser chromium --spec '${{ matrix.specs }}' | |||
There was a problem hiding this comment.
Is these CYPRESS_NO_COMMAND_LOG remove by intentionally? As I remeber we add this variable to unhang before.
There was a problem hiding this comment.
Yes, by reducing the defaultCommandTimeout to 10000, the test is able to run without hang. So I removed the command log env so that the video can give more info for debugging.
|
Reverted #1408 and the corresponding ones in 2.15 branch. Please come back with another commit later. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 03548a6 from #1408