[Maps Plugin] Fix disable check in Maps new home integ tests #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Qin <qinandy@amazon.com>
q-andy
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
q-andy
changed the title
ruanyl
approved these changes
Feb 12, 2025
ohltyler
approved these changes
Feb 12, 2025
peterzhuamazon
approved these changes
Feb 12, 2025
peterzhuamazon
merged commit cc59ede
into
opensearch-project:main
37 of 39 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Andy Qin <qinandy@amazon.com> (cherry picked from commit cc59ede)
peterzhuamazon
pushed a commit
that referenced
this pull request
Feb 12, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Andy Qin <qinandy@amazon.com> (cherry picked from commit cc59ede)
|
Requested by @q-andy to backport to 2.17. |
peterzhuamazon
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix overly strict disable check in flaky integ test added in #1587
When an element is disabled, the disabled property is not always set to
disabled='disabled'. Sometimes it is set withdisabled=''or as a property without a value,disabled. In those cases, the test would not be skipped and the integ test fails since the switch is still disabled.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.