Improve the assertion in left navigation recent history test to avoid flakiness #1717
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriedhelmWS
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
Signed-off-by: Owen Wang <owenwyk@amazon.com>
SuZhou-Joe
approved these changes
Feb 17, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
Signed-off-by: Owen Wang <owenwyk@amazon.com> (cherry picked from commit c064e03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional assertion to avoid flakiness.
This is caused by loading icon can appear/hide twice on the screen, once for loading the page (first loading) and once for loading the visualisation list (second loading). Between two loading period, the recent history button could appear on the screen for milliseconds and then being replaced by loading icon again by the second loading.
In a rare slow network case, Cypress can potentially got the recent history button successfully during the interval between two loading period. However, when Cypress attempt to click on the button it already selected, the button itself could already disappear and being replaced by loading icon during the second loading, result in test failure.
This PR adds an additional assertion to ensure the page is fully loaded (i.e. the visualisation list finish loading completely) so that avoids the falkiness test result.
Screen.Recording.2025-02-17.at.11.32.15.mov
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.