Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional VisBuilder tests and commands #340

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Oct 19, 2022

Signed-off-by: Ashwin Pc ashwinpc@amazon.com

Description

Visbuilder Tests

  • Updates Basic test
  • Adds Dashboard test for visbuilder visualizations
  • Adds Experimental test for visbuilder
  • Adds Basic tests for each visualization type

Visbuilder misc

  • Adds additional data and saved objects for Visbuilder tests
  • Adds Edit agg visbuilder command
  • Updates common commands and consolidates variables

General

  • Adds importSavedObjects command
  • Adds deleteSavedObject command
  • Adds deleteSavedObjectByType command
  • Adds setAdvancedSetting command

Test Videos

Basic test (Updated)

basic.spec.js.mp4

Dashboard test

dashboard.spec.js.mp4

Experimental test

experimental.spec.js.mp4

Vis Types:

Metric:

metric.spec.js.mp4

Bar Chart:

bar.spec.js.mp4

Line Chart:

line.spec.js.mp4

Area Chart:

area.spec.js.mp4

Note: Depends on opensearch-project/OpenSearch-Dashboards#2610 being merged and built

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashwin-pc ashwin-pc requested a review from a team as a code owner October 19, 2022 01:13
@ashwin-pc
Copy link
Member Author

The two failing tests have corresponding fixes in opensearch-project/OpenSearch-Dashboards#2610 which has been merged. @tianleh how long before we can rerun these tests so that those changes are picked up?

@tianleh
Copy link
Member

tianleh commented Oct 20, 2022

The two failing tests have corresponding fixes in opensearch-project/OpenSearch-Dashboards#2610 which has been merged. @tianleh how long before we can rerun these tests so that those changes are picked up?

Just see a new successful build.


BUILD_NUMBER=[4175]
MESSAGE=Successful Build
BUILD_URL: https://build.ci.opensearch.org/job/distribution-build-opensearch-dashboards/4175/
MANIFEST: 3.0.0/opensearch-dashboards-3.0.0.yml

let me rerun the workflow.

@tianleh
Copy link
Member

tianleh commented Oct 20, 2022

The new run still has a failed test https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3285900713/jobs/5429768670 Could you take a look? @ashwin-pc

The build links shows that "[Vis Builder] Update vislib params and misc fixes (#2610)" was included in the build.

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
@tianleh
Copy link
Member

tianleh commented Oct 21, 2022

Please add the backport label if needed.

@seraphjiang seraphjiang merged commit a6579b1 into opensearch-project:main Oct 24, 2022
@seraphjiang
Copy link
Member

Please add the backport label if needed.

@tianleh @CCongWang

One observation, not every contributor has permission to add label. In such case, maintainer should take responsibility to triage and add label

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-340-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6579b1e25a1712794d1865e8fc49c9aacfd5337
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-340-to-2.x.

@seraphjiang seraphjiang added v2.4.0 'Issues and PRs related to version v2.4.0' enhancement New feature or request labels Oct 25, 2022
@ashwin-pc
Copy link
Member Author

@tianleh Looks like the automated backport failed. Will you be creating a manual backport for this?

@tianleh
Copy link
Member

tianleh commented Oct 25, 2022

@tianleh Looks like the automated backport failed. Will you be creating a manual backport for this?

After merging another backporting change and re-triggering the backporting workflow by removing and adding the label, the backport is now automatically created #350 @ashwin-pc

seraphjiang pushed a commit that referenced this pull request Oct 27, 2022
(cherry picked from commit a6579b1)

Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants