-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional VisBuilder tests and commands #340
Conversation
The two failing tests have corresponding fixes in opensearch-project/OpenSearch-Dashboards#2610 which has been merged. @tianleh how long before we can rerun these tests so that those changes are picked up? |
Just see a new successful build.
let me rerun the workflow. |
The new run still has a failed test https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3285900713/jobs/5429768670 Could you take a look? @ashwin-pc The build links shows that "[Vis Builder] Update vislib params and misc fixes (#2610)" was included in the build. |
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Please add the backport label if needed. |
One observation, not every contributor has permission to add label. In such case, maintainer should take responsibility to triage and add label |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-340-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6579b1e25a1712794d1865e8fc49c9aacfd5337
# Push it to GitHub
git push --set-upstream origin backport/backport-340-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@tianleh Looks like the automated backport failed. Will you be creating a manual backport for this? |
(cherry picked from commit a6579b1)
After merging another backporting change and re-triggering the backporting workflow by removing and adding the label, the backport is now automatically created #350 @ashwin-pc |
Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
Visbuilder Tests
Visbuilder misc
General
importSavedObjects
commanddeleteSavedObject
commanddeleteSavedObjectByType
commandsetAdvancedSetting
commandTest Videos
Basic test (Updated)
basic.spec.js.mp4
Dashboard test
dashboard.spec.js.mp4
Experimental test
experimental.spec.js.mp4
Vis Types:
Metric:
metric.spec.js.mp4
Bar Chart:
bar.spec.js.mp4
Line Chart:
line.spec.js.mp4
Area Chart:
area.spec.js.mp4
Note: Depends on opensearch-project/OpenSearch-Dashboards#2610 being merged and built
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.