[Table visualization] Add functional tests for new table vis #423

ananzh · 2022-12-13T02:42:14Z

Description

There are five test cases:

basic.spec.js contains tests related to vis page, like inspector, save an object.

basic.mov

data.spec.js tests diff metrics and buckets aggregations.

data.mov

options.spec.js contains tests on options panel.

options.mov

split.spec.js tests table functions, like sort, adjust col width, split tables and etc.

split.mov

embed.spec.js tests how an embedded table visualization works.

embed.mov

Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests.

Partially Resolved

#401

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ashwin-pc · 2022-12-17T01:21:14Z

...tegration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/basic.spec.js

+    cy.deleteIndex(TABLE_INDEX_ID);
+    cy.deleteIndexPattern(TABLE_INDEX_PATTERN);
+    cy.bulkUploadDocs(TABLE_PATH_INDEX_DATA);
+    cy.createIndexPattern(TABLE_INDEX_PATTERN, {


your saved object seems to already have the required index pattern. Do you still need to run this command?

Yes. For saved index pattern, I used two ways to test in table.

Manually add an index pattern in saved object then create a table vis cy.createIndexPattern. This is used in basic.spec.js

Import an saved object through cy.importSavedObjects(TABLE_PATH_SO_DATA). This method is used in other three tests.

Basically I would like to try both to make sure table vis can created from both ways.

ashwin-pc · 2022-12-17T01:23:14Z

cypress/utils/dashboards/vis_type_table/buckets_agg.js

+ * Terms Aggregation
+ */
+
+Cypress.Commands.add('toggleOtherBucket', (request) => {


Can we add prefixes to these custom commands? I can see other commands being named similarly. e.g for VisBuilder specific commands i prefixed them with vb so that there arent two commands with the same name.

Good call. I didn't realize that. I will update the command names and add a prefix tb to all of them, which represents table. If tb is ambiguous, pls let me know.

ashwin-pc · 2022-12-17T01:24:54Z

...tegration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/basic.spec.js

+  it('Should allow applying changed params', () => {
+    cy.setHistogramInterval('201', 2);
+    cy.isUpdateAggregationSettingsEnabled();
+  });


Each test should be atomic. so that even if one test does not pass, the next test runs without being affected.

Got it. I will modify this one. Thank you.

tianleh · 2023-02-15T22:13:18Z

@ananzh Do you need confirmation from Ashwin before merging? If not, we can approve and get it merged.

ashwin-pc · 2023-03-02T21:32:07Z

@tianleh no you do not :) I only had minor comments on the original PR. Sorry @ananzh for letting this slip through the cracks, this PR however might need to be rebased since some of the changes seem to be irrelevant to the PR and all the checks do not pass right now.

There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: opensearch-project#401 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f)

…671) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com>

…672) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: #401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: #439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com>

…rch-project#423) (opensearch-project#671) * [Table visualization] Add functional tests for new table vis There are four test cases: * basic.spec.js contains tests related to vis page, like inspector, save an object. * data.spec.js tests diff metrics and buckets aggregations. * options.spec.js contains tests on options panel. * split.spec.js tests table functions, like sort, adjust col width, split tables and etc. Most tests are the same as the removed funtional tests. split.spec.js is the only one with all new tests. Partially Resolved: opensearch-project#401 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * fix test error and add embed test suite Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix multiple submit bug Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * missed conflict resolution Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 3dffb5f) Co-authored-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>

ananzh requested a review from a team as a code owner December 13, 2022 02:42

ananzh requested a review from ashwin-pc December 13, 2022 02:42

ananzh force-pushed the vis-table branch from 58c371b to 15e6f2e Compare December 13, 2022 23:15

ananzh mentioned this pull request Dec 16, 2022

[Table Visualization] Replace table visualization with React and DataGrid opensearch-project/OpenSearch-Dashboards#2863

Merged

8 tasks

ashwin-pc reviewed Dec 17, 2022

View reviewed changes

ananzh force-pushed the vis-table branch 2 times, most recently from aa52db0 to 4abd9ce Compare January 10, 2023 20:32

ananzh self-assigned this Jan 10, 2023

ananzh force-pushed the vis-table branch from f8fd3b8 to b904dab Compare February 1, 2023 23:01

ananzh mentioned this pull request Feb 2, 2023

[Bug] 3.0.0 build fail for a long while opensearch-project/opensearch-build#3173

Closed

ananzh mentioned this pull request Apr 12, 2023

[BUG] functional test fail due to build on main fail opensearch-project/opensearch-build#3390

Closed

ashwin-pc self-assigned this Mar 29, 2023

ananzh added 4 commits May 18, 2023 16:47

fix PR comments

7a4f255

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

fix test error and add embed test suite

82270e4

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Fix multiple submit bug

b72bc25

Currently there are two submit type button in data source which cause cypress fail to find and click. In this PR, I switch to use data-test-subj to uniquely identify the btn. Issue Resolved: opensearch-project#439 Signed-off-by: Anan Zhuang <ananzh@amazon.com>

kavilla force-pushed the vis-table branch from b904dab to b72bc25 Compare May 18, 2023 16:48

kavilla requested review from tianleh, kavilla, ohltyler, CCongWang and peterzhuamazon as code owners May 18, 2023 16:48

missed conflict resolution

03c4156

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla added backport 2.x backport 2.7 labels May 18, 2023

kavilla approved these changes May 24, 2023

View reviewed changes

CCongWang approved these changes May 24, 2023

View reviewed changes

kavilla merged commit 3dffb5f into opensearch-project:main May 24, 2023

opensearch-trigger-bot bot mentioned this pull request May 24, 2023

[Backport 2.x] [Table visualization] Add functional tests for new table vis #671

Merged

opensearch-trigger-bot bot mentioned this pull request May 24, 2023

[Backport 2.7] [Table visualization] Add functional tests for new table vis #672

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Table visualization] Add functional tests for new table vis #423

[Table visualization] Add functional tests for new table vis #423

ananzh commented Dec 13, 2022 •

edited

Loading

ashwin-pc Dec 17, 2022

ananzh Jan 9, 2023 •

edited

Loading

ashwin-pc Dec 17, 2022

ananzh Jan 9, 2023 •

edited

Loading

ashwin-pc Dec 17, 2022

ananzh Jan 9, 2023

tianleh commented Feb 15, 2023

ashwin-pc commented Mar 2, 2023

[Table visualization] Add functional tests for new table vis #423

[Table visualization] Add functional tests for new table vis #423

Conversation

ananzh commented Dec 13, 2022 • edited Loading

Description

Partially Resolved

Check List

ashwin-pc Dec 17, 2022

Choose a reason for hiding this comment

ananzh Jan 9, 2023 • edited Loading

Choose a reason for hiding this comment

ashwin-pc Dec 17, 2022

Choose a reason for hiding this comment

ananzh Jan 9, 2023 • edited Loading

Choose a reason for hiding this comment

ashwin-pc Dec 17, 2022

Choose a reason for hiding this comment

ananzh Jan 9, 2023

Choose a reason for hiding this comment

tianleh commented Feb 15, 2023

ashwin-pc commented Mar 2, 2023

ananzh commented Dec 13, 2022 •

edited

Loading

ananzh Jan 9, 2023 •

edited

Loading

ananzh Jan 9, 2023 •

edited

Loading