Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppress observer for table vis test #969

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

abbyhu2000
Copy link
Member

Description

Add suppress observer for table vis test cigroup2. Also fix the typo in the function name.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I was thinking, if this error can be safely ignored, shall we add it to one single place so it won't repeat everywhere?

@ruanyl ruanyl merged commit 73f6db1 into opensearch-project:main Jan 22, 2024
33 of 38 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-969-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73f6db1b968c3c164ef2554851cf8c3bd97e5987
# Push it to GitHub
git push --set-upstream origin backport/backport-969-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-969-to-2.x.

@ruanyl
Copy link
Member

ruanyl commented Jan 23, 2024

Hi @abbyhu2000, the backport to 2.x has failed, could you backport manually please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants