Add point in time api #253
Conversation
|
ToDo:
|
Jakob3xD
force-pushed
the
feature-poin-in-time
branch
2 times, most recently
from
1b09f7a to
f9f678b
Compare
|
@dblock does this lib aim to be a low level lib or should it be more user friendly? |
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Jakob3xD
force-pushed
the
feature-poin-in-time
branch
from
f9f678b to
98b665e
Compare
I definitely think we want to minimize the amount of work a user has to do. So as much user friendly as possible, but also letting users go deep into low level constructs. |
Jakob3xD
force-pushed
the
feature-poin-in-time
branch
2 times, most recently
from
238981c to
8f56714
Compare
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Jakob3xD
force-pushed
the
feature-poin-in-time
branch
from
8f56714 to
f334868
Compare
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
| // Modifications Copyright OpenSearch Contributors. See | ||
| // GitHub history for details. | ||
|
|
||
| // Licensed to Elasticsearch B.V. under one or more contributor |
There was a problem hiding this comment.
This is new code? We don't need a ES grant, remove this license part below.
There was a problem hiding this comment.
Question for me as I am not into such license things.
Can I remove the ES grant if it is new code but follows the same scheme and has similarity to code that has ES grant? As the Withxyz() functions are all the same.
There was a problem hiding this comment.
IANAL, but if you copied any code with such license then we should probably keep it. But if it's new code then we don't need it. Check out https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#license-headers for more info.
…e response.Err() Signed-off-by: Vacha Shah <vachshah@amazon.com>
#322) * Revert "Draft: Add Err() function to Response for detailed errors (#246)" This reverts commit 8d3cf4d. Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing PIT APIs introduced in PR #253 since they use response.Err() Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing opensearchapi.Error usage from snapshot tests introduced in PR #237 Signed-off-by: Vacha Shah <vachshah@amazon.com> * Resolve Changelog conflicts Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
opensearch-project#322) * Revert "Draft: Add Err() function to Response for detailed errors (opensearch-project#246)" This reverts commit 8d3cf4d. Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing PIT APIs introduced in PR opensearch-project#253 since they use response.Err() Signed-off-by: Vacha Shah <vachshah@amazon.com> * Removing opensearchapi.Error usage from snapshot tests introduced in PR opensearch-project#237 Signed-off-by: Vacha Shah <vachshah@amazon.com> * Resolve Changelog conflicts Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
#322) (#384) * Revert "Draft: Add Err() function to Response for detailed errors (#246)" This reverts commit 8d3cf4d. * Fixing PIT APIs introduced in PR #253 since they use response.Err() * Removing opensearchapi.Error usage from snapshot tests introduced in PR #237 * Resolve Changelog conflicts --------- Signed-off-by: Vacha Shah <vachshah@amazon.com>
Description
Add the Point in Time API.
https://opensearch.org/docs/latest/search-plugins/point-in-time-api/
Issues Resolved
Closes #251
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.