-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-run codegen #1216
Merged
Merged
Re-run codegen #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
September 30, 2024 23:55
Xtansia
force-pushed
the
fix/update-codegen
branch
2 times, most recently
from
October 1, 2024 04:04
727d3a7
to
3c0a405
Compare
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
force-pushed
the
fix/update-codegen
branch
from
October 1, 2024 04:09
3c0a405
to
b896411
Compare
dblock
approved these changes
Oct 1, 2024
Xtansia
added a commit
to Xtansia/opensearch-java
that referenced
this pull request
Oct 1, 2024
* Re-run codegen Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve null handling Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 897cc9b)
Xtansia
added a commit
to Xtansia/opensearch-java
that referenced
this pull request
Oct 1, 2024
* Re-run codegen Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve null handling Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 897cc9b)
Xtansia
added a commit
that referenced
this pull request
Oct 1, 2024
* Generate hashCode and equals (#1201) * Generate hashCode and equals , wip Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add changelog entry Signed-off-by: miguel-vila <miguelvilag@gmail.com> * remove change Signed-off-by: miguel-vila <miguelvilag@gmail.com> * take into account primitives Signed-off-by: miguel-vila <miguelvilag@gmail.com> * refactor and format Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use Object.equals Co-authored-by: Thomas Farr <xtansia@xtansia.com> Signed-off-by: Miguel Vilá <miguelvilag@gmail.com> * use `&&` chain Signed-off-by: miguel-vila <miguelvilag@gmail.com> * adjust last line Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use fqn Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use fqn for Objects.hashCode, take into account parent Signed-off-by: miguel-vila <miguelvilag@gmail.com> * remove unused var definition Signed-off-by: miguel-vila <miguelvilag@gmail.com> * codegen equals/hashCode for request shapes Signed-off-by: miguel-vila <miguelvilag@gmail.com> * add hashCode/equals to TaggedUnion Signed-off-by: miguel-vila <miguelvilag@gmail.com> * use import Signed-off-by: miguel-vila <miguelvilag@gmail.com> * fix equals for request shapes Signed-off-by: miguel-vila <miguelvilag@gmail.com> * codegen latest from main Signed-off-by: miguel-vila <miguelvilag@gmail.com> --------- Signed-off-by: miguel-vila <miguelvilag@gmail.com> Signed-off-by: Miguel Vilá <miguelvilag@gmail.com> Co-authored-by: Thomas Farr <xtansia@xtansia.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 18a8460) * Re-run codegen (#1216) * Re-run codegen Signed-off-by: Thomas Farr <tsfarr@amazon.com> * Improve null handling Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 897cc9b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some missed classes in #1201 due to not being recently rebased
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.