Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for radial search on Neural query #1235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 18, 2024

Description

Add support for radial search on k-NN and Neural query types

Issues Resolved

Fixes #1226

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia added the backport 2.x Backport to 2.x branch label Oct 18, 2024
@Xtansia Xtansia removed the backport 2.x Backport to 2.x branch label Oct 18, 2024
@dblock
Copy link
Member

dblock commented Oct 18, 2024

I see the parameters present in the API spec. How far are we from getting this via the code generator?

@Xtansia
Copy link
Collaborator Author

Xtansia commented Oct 21, 2024

I see the parameters present in the API spec. How far are we from getting this via the code generator?

The query types (plus a couple others) have special deserialization logic for handling the fact they're "single key dictionaries", keyed on field, and in Java (and .NET) the field value gets flattened into the same class as the other query properties. So requires tweaking the spec to be consistent in how they're represented to be able to add special handling to the generator. It is one of the next things I'm going to look into, and will need to make sure the spec changes work for the people working on protobuf representation of the search api.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia changed the title Add support for radial search on k-NN and Neural query types Add support for radial search on Neural query Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for Radial Search in Neural Query
2 participants