Support DataStream APIs #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, and support specified data stream timestamp field in PutIndexTemplate. Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com>
tanqiuliu
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com>
|
The test failures are all because of the following test This is not relevant to the changes in this PR. The same test failure also appeared in previous PRs: link1, link2. When I try to reproduce the issue in local, it seems to be an intermittent issue which appears once among ten runs. It failed due to exception when search an index: I am not quite sure about the root cause. |
That's the flaky one sadly, #407 |
reta
previously approved these changes
Mar 27, 2023
VachaShah
previously approved these changes
Mar 27, 2023
There was a problem hiding this comment.
LGTM, thank you @tanqiuliu for adding this feature!
Can we also add this to the USER_GUIDE?
Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com>
VachaShah
reviewed
Mar 28, 2023
| @@ -214,6 +214,53 @@ DeleteIndexRequest deleteIndexRequest = new DeleteRequest.Builder().index(index) | |||
| DeleteIndexResponse deleteIndexResponse = client.indices().delete(deleteIndexRequest); | |||
| ``` | |||
|
|
|||
| ## Data Stream API | |||
There was a problem hiding this comment.
Sorry one more comment: can you add the new section to TOC as well?
Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com>
reta
approved these changes
Mar 28, 2023
VachaShah
approved these changes
Mar 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Add CreateDataStream, GetDataStream, DeleteDataStream, DataStreamsStats, and support specified data stream timestamp field in PutIndexTemplate. Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Add change log for data stream changes Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Add data stream into user guide Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * add data stream to TOC of user guide Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> --------- Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> (cherry picked from commit 876d379) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Add CreateDataStream, GetDataStream, DeleteDataStream, DataStreamsStats, and support specified data stream timestamp field in PutIndexTemplate. * Add change log for data stream changes * Add data stream into user guide * add data stream to TOC of user guide --------- (cherry picked from commit 876d379) Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CreateDataStream,DeleteDataStream,GetDataStream,DataStreamsStats)timestamp_fieldfordataStreaminPutIndexTemplateIssues Resolved
#402
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.