fix: add missing highlight and source field in MultisearchBody.Builder #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczepanczykd
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
szczepanczykd
force-pushed
the
feature/multisearch-body-missing-highlight-and-source-fix-441
branch
from
a0b467b
to
ccd7afe
Compare
szczepanczykd
changed the title
reta
approved these changes
Apr 11, 2023
VachaShah
approved these changes
Apr 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
#442) * fix: add missing highlight and source field in MultisearchBody.Builder Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> --------- Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> (cherry picked from commit c050365) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
szczepanczykd
deleted the
feature/multisearch-body-missing-highlight-and-source-fix-441
branch
szczepanczykd
added a commit
to szczepanczykd/opensearch-java
that referenced
this pull request
Apr 12, 2023
opensearch-project#442) * fix: add missing highlight and source field in MultisearchBody.Builder Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> --------- Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
VachaShah
pushed a commit
that referenced
this pull request
Apr 12, 2023
* fix: add missing highlight and source field in MultisearchBody.Builder (#442) * fix: add missing highlight and source field in MultisearchBody.Builder Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * update CHANGELOG.md Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> --------- Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> * fix: use apache HttpHost Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com> --------- Signed-off-by: Dominik Szczepanczyk <szczepanczyk.dominik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we can use Highlights and SourceConfig in Multisearch Request.
Issues Resolved
#441
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.