fix: add several missing fields in MultisearchBody.Builder (#506) #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mstrutov
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Mstrutov
force-pushed
the
fix/add-fields-to-msearch-body-506
branch
2 times, most recently
from
c8dcdb2
to
56d1d7b
Compare
…h-project#506) - add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
Mstrutov
force-pushed
the
fix/add-fields-to-msearch-body-506
branch
from
56d1d7b
to
78869cb
Compare
reta
approved these changes
Jun 5, 2023
VachaShah
approved these changes
Jun 5, 2023
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Jun 6, 2023
…h-project#506) (opensearch-project#516) * fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506) - add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> * update CHANGELOG.md Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> --------- Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Jun 6, 2023
…h-project#506) (opensearch-project#516) * fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506) - add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> * update CHANGELOG.md Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> --------- Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com>
reta
pushed a commit
to reta/opensearch-java
that referenced
this pull request
Jun 6, 2023
…h-project#506) (opensearch-project#516) * fix: add several missing fields in MultisearchBody.Builder (opensearch-project#506) - add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> * update CHANGELOG.md Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> --------- Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
that referenced
this pull request
Jun 6, 2023
…) (#519) * fix: add several missing fields in MultisearchBody.Builder (#506) - add minScore, postFilter, searchAfter, sort, trackScores to MultisearchBody * update CHANGELOG.md --------- Signed-off-by: Maksim Strutovskii <strutovsky.m.a@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Mstrutov <41866740+Mstrutov@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we can use minScore, postFilter, searchAfter, sort and trackScores in Multisearch Request.
Issues Resolved
Closes #506
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.